Bug 215828 - sysutils/freebsd-snapshot limits maximum number of zfs snapshots to 20
Summary: sysutils/freebsd-snapshot limits maximum number of zfs snapshots to 20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-06 13:43 UTC by hostmaster
Modified: 2019-02-26 04:53 UTC (History)
4 users (show)

See Also:
hostmaster: maintainer-feedback+

Attachments
for "periodic-snapshot" - allows to zfs filesystems to have unlimited snapshots (1.58 KB, patch)
2017-01-06 13:43 UTC, hostmaster 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hostmaster 2017-01-06 13:43:24 UTC 
Created attachment 178574 [details]
for "periodic-snapshot" - allows to zfs filesystems to have unlimited snapshots

the periodic-snapshot supplied with the sysutils/freebsd-snapshot port limits the total number of snapshots per file system to 20, which is correct for ufs filesystems but does not apply to zfs which can have 2^64

A patch is included which fixes this small flaw in an otherwise very handy utility
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-01-14 05:26:52 UTC 
Maintainer feedback?
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2019-02-26 04:44:53 UTC 
LGTM. Maintainer timeout.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-02-26 04:52:15 UTC 
A commit references this bug:

Author: meta
Date: Tue Feb 26 04:51:49 UTC 2019
New revision: 493933
URL: https://svnweb.freebsd.org/changeset/ports/493933

Log:
  sysutils/freebsd-snapshot: allows to zfs filesystems to have unlimited snapshots

  The periodic-snapshot supplied with the sysutils/freebsd-snapshot port
  limits the total number of snapshots per file system to 20, which is
  correct for ufs filesystems but does not apply to zfs which can have 2^64.

  PR:		215828
  Submitted by:	hostmaster@GTS.NET
  Approved by:	maintainer timeout

Changes:
  head/sysutils/freebsd-snapshot/Makefile
  head/sysutils/freebsd-snapshot/files/patch-allow-unlimited-snapshots-on-zfs
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2019-02-26 04:53:12 UTC 
Committed, thanks!