Bug 216217 - multimedia/vdr-plugin-epgsearch: fails to build with clang 4.0
Summary: multimedia/vdr-plugin-epgsearch: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-18 08:38 UTC by Jan Beich
Modified: 2017-02-01 13:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-18 08:38:12 UTC 
epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
         while (fgets(buffer, sizeof(buffer), f) > 0) {
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

build log: http://sprunge.us/cZBR
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:26:02 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:02 UTC 2017
New revision: 432968
URL: https://svnweb.freebsd.org/changeset/ports/432968

Log:
  multimedia/vdr-plugin-epgsearch: unbreak with clang 4.0

  createcats.c:67:42: error: ordered comparison between pointer and zero ('char *' and 'int')
      if (fgets(buffer, sizeof(buffer), f) > 0) {
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
           while (fgets(buffer, sizeof(buffer), f) > 0) {
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

  PR:		216217
  Reported by:	antoine (via exp-run)

Changes:
  head/multimedia/vdr-plugin-epgsearch/files/patch-clang40
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:26:04 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:25:16 UTC 2017
New revision: 432969
URL: https://svnweb.freebsd.org/changeset/ports/432969

Log:
  multimedia/vdr-plugin-vdrmanager: unbreak with clang 4.0

  sock.cpp:23:13: error: ordered comparison between pointer and zero ('int (*)(int, int, int)' and 'int')
          if (socket >= 0) {
              ~~~~~~ ^  ~

  PR:		216217
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream

Changes:
  head/multimedia/vdr-plugin-vdrmanager/Makefile
  head/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-02-01 12:59:25 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 12:58:41 UTC 2017
New revision: 433028
URL: https://svnweb.freebsd.org/changeset/ports/433028

Log:
  MFH: r432968

  multimedia/vdr-plugin-epgsearch: unbreak with clang 4.0

  createcats.c:67:42: error: ordered comparison between pointer and zero ('char *' and 'int')
      if (fgets(buffer, sizeof(buffer), f) > 0) {
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  epgsearchext.c:1506:50: error: ordered comparison between pointer and zero ('char *' and 'int')
           while (fgets(buffer, sizeof(buffer), f) > 0) {
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
  c++: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]

  PR:		216217
  Reported by:	antoine (via exp-run)
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/vdr-plugin-epgsearch/files/patch-clang40
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-02-01 13:00:28 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 13:00:03 UTC 2017
New revision: 433029
URL: https://svnweb.freebsd.org/changeset/ports/433029

Log:
  MFH: r432969

  multimedia/vdr-plugin-vdrmanager: unbreak with clang 4.0

  sock.cpp:23:13: error: ordered comparison between pointer and zero ('int (*)(int, int, int)' and 'int')
          if (socket >= 0) {
              ~~~~~~ ^  ~

  PR:		216217
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/multimedia/vdr-plugin-vdrmanager/Makefile
  branches/2017Q1/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp