Bug 216358 - x11/antimicro: fails to build with clang 4.0
Summary: x11/antimicro: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-21 19:22 UTC by Jan Beich
Modified: 2017-02-01 05:32 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-21 19:22:30 UTC 
src/mainwindow.cpp:367:19: error: ordered comparison between pointer and zero ('QMap<SDL_JoystickID, InputDevice *> *' (aka 'QMap<int, InputDevice *> *') and 'int')
    if (joysticks > 0)
        ~~~~~~~~~ ^ ~

build log: http://sprunge.us/QNMU
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:28:17 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:27:47 UTC 2017
New revision: 432980
URL: https://svnweb.freebsd.org/changeset/ports/432980

Log:
  x11/antimicro: unbreak with clang 4.0

  src/mainwindow.cpp:367:19: error: ordered comparison between pointer and zero ('QMap<SDL_JoystickID, InputDevice *> *' (aka 'QMap<int, InputDevice *> *') and 'int')
      if (joysticks > 0)
          ~~~~~~~~~ ^ ~

  PR:		216358
  Reported by:	antoine (via exp-run)

Changes:
  head/x11/antimicro/Makefile
  head/x11/antimicro/files/
  head/x11/antimicro/files/patch-src_mainwindow.cpp