Bug 216904 - x11/wmmp New port proposal for WMmp
Summary: x11/wmmp New port proposal for WMmp
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 07:58 UTC by Nicolas Herry
Modified: 2017-12-05 18:26 UTC (History)
0 users

See Also:


Attachments
shar archive for wmmp (1.76 KB, text/plain)
2017-02-08 07:58 UTC, Nicolas Herry
no flags Details
new version of shar archive for wmmp: 0.12.0 (1.76 KB, text/plain)
2017-02-19 15:23 UTC, Nicolas Herry
no flags Details
new version of shar archive for wmmp: 0.12.1 (1.77 KB, text/plain)
2017-02-22 22:08 UTC, Nicolas Herry
no flags Details
poudriere log for wmmp-0.12.1 (27.13 KB, text/plain)
2017-02-22 22:09 UTC, Nicolas Herry
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Herry 2017-02-08 07:58:07 UTC
Created attachment 179744 [details]
shar archive for wmmp

x11/wmmp
New port proposal for WMmp, a simple dockable musicpd client for Window Maker.
Comment 1 Nicolas Herry 2017-02-19 15:23:19 UTC
Created attachment 180144 [details]
new version of shar archive for wmmp: 0.12.0

New version of the shar archive for the port: target 0.12.0, which cleans up a few things.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2017-02-22 10:27:47 UTC
===>  Configuring for wmmp-0.12.0
configure.ac:18: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf-2.69: /usr/local/bin/autoconf-2.69 failed with exit status: 1
*** Error code 1
Comment 3 Nicolas Herry 2017-02-22 10:37:43 UTC
How do you obtain this error?

Following the steps described in https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html, I don't get this error.

Since this is my first port, I guess I must be doing something wrong; could you provide me with some guidance to fix this?
Thanks!
Comment 4 Nicolas Herry 2017-02-22 11:31:53 UTC
Reading this: https://www.freebsd.org/doc/en/books/porters-handbook/uses-autoreconf.html and this: https://www.freebsd.org/doc/en/books/porters-handbook/using-autotools.html makes me think that the USES= directive in the Makefile is incomplete.

I'll work on it this evening, test in a clean environment (where libtool is not installed yet). Apologies for the mess.
Comment 5 Nicolas Herry 2017-02-22 22:08:34 UTC
Created attachment 180233 [details]
new version of shar archive for wmmp: 0.12.1

Includes changes to autotools (libtool in particular).
Comment 6 Nicolas Herry 2017-02-22 22:09:22 UTC
Created attachment 180234 [details]
poudriere log for wmmp-0.12.1

poudriere logs for wmmp-0.12.1.
Comment 7 Nicolas Herry 2017-02-22 22:10:15 UTC
Following the issue with the autotools (and libtool in particular), I made a few changes to both the port Makefile and the autotools files in the application.

Tested with:
- the sequence described in https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html
- poudriere, as described in https://www.freebsd.org/doc/en/books/porters-handbook/testing-poudriere.html

Hope I got things right this time.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-12-05 18:26:08 UTC
A commit references this bug:

Author: amdmi3
Date: Tue Dec  5 18:26:00 UTC 2017
New revision: 455600
URL: https://svnweb.freebsd.org/changeset/ports/455600

Log:
  WMmp is a dockable musicpd (MPD) client applet for Window Maker.

  It offers controls to play, pause, stop the music, as well as
  navigate back and forth the current playlist.

  musicpd volume can be set with the mouse wheel.

  WWW: https://github.com/yogsothoth/wmmp

  PR:		216904
  Submitted by:	nicolasherry@gmail.com

Changes:
  head/audio/Makefile
  head/audio/wmmp/
  head/audio/wmmp/Makefile
  head/audio/wmmp/distinfo
  head/audio/wmmp/pkg-descr
  head/audio/wmmp/pkg-plist
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2017-12-05 18:26:13 UTC
(changed category to audio).