Bug 216987 - shells/fish
Summary: shells/fish
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Alan Somers
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2017-02-11 01:52 UTC by Keren Sky
Modified: 2017-02-11 05:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (asomers)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keren Sky 2017-02-11 01:52:06 UTC 
Hi,
 Upon invoking fish after installing, one sees the following:

fish: Unknown command 'python -B /usr/local/share/fish/tools/create_manpage_completions.py --manpath --progress --cleanup-in ~/.config/fish/completions --cleanup-in ~/.config/fish/generated_completions'
/usr/local/share/fish/functions/fish_update_completions.fish (line 2):  python -B $__fish_datadir/tools/create_manpage_completions.py --manpath --progress --cleanup-in '~/.config/fish/completions' --cleanup-in '~/.config/fish/generated_completions'
                                                                        ^
in function ���fish_update_completions���
        called on standard input

���      

I only have 'python2' and a 'python3' but no 'python' in the various 'bin' dirs.

Cheers
Comment 1 Alan Somers freebsd_committer freebsd_triage 2017-02-11 02:56:46 UTC 
I can reproduce it.  I'll fix it.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-11 05:23:28 UTC 
A commit references this bug:

Author: asomers
Date: Sat Feb 11 05:23:19 UTC 2017
New revision: 433836
URL: https://svnweb.freebsd.org/changeset/ports/433836

Log:
  shells/fish: fix completions for python

  Eliminate errors during command completion for python, python2, and python3 if
  the /usr/local/bin/python symlink does not exist.  Additionally, even if the
  symlink does exist, the completions will be wrong for the non-default
  interpreter.  So I'm simply deleting the problematic completions altogether.  I
  opened an upstream bug for the latter issue.

  https://github.com/fish-shell/fish-shell/issues/3840

  While I'm here, delete an extraneous patch file for DOCS=off

  PR:		216987
  Reported by:	Keren Sky <keren_sky@live.com>
  Approved by:	brd (ports, implicit)

Changes:
  head/shells/fish/Makefile
  head/shells/fish/files/extra-patch-Makefile.in
  head/shells/fish/files/patch-share_completions_python.fish