Bug 217182 - x11/xlockmore: set FORTUNE = /usr/bin/fortune
Summary: x11/xlockmore: set FORTUNE = /usr/bin/fortune
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-17 20:26 UTC by Richard Narron
Modified: 2017-03-21 17:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jgh)


Attachments
patch to modes/Makefile.in to set FORTUNE = /usr/bin/fortune (363 bytes, patch)
2017-02-17 20:26 UTC, Richard Narron
no flags Details | Diff
Patch to the port Makefile for version 5.51 of xlockmore (807 bytes, patch)
2017-03-21 11:07 UTC, Richard Narron
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Narron 2017-02-17 20:26:57 UTC
Created attachment 180088 [details]
patch to modes/Makefile.in to set FORTUNE = /usr/bin/fortune

"xlockmore -mode nose" uses the fortune program to display a witty saying.

Unfortunately on FreeBSD 11 it displays this: "sh: /usr/games/fortune not found"

This needs to be changed...

Attached is a patch to the modes/Makefile.in file to change the fortunes program to /usr/bin/fortune

There are better ways to fix this.  

Ideally the maintainers of xlockmore would provide a configure parameter to set the location of the fortune program...
Comment 1 Richard Narron 2017-03-21 11:07:53 UTC
Created attachment 181026 [details]
Patch to the port Makefile for version 5.51 of xlockmore

Had to remove the ${STAGEFILE} parameters from the MAKE_ARGS
Comment 2 Richard Narron 2017-03-21 11:12:07 UTC
David Bagley is still actively supporting xlockmore at http://sillycycle.com/
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-21 17:37:40 UTC
A commit references this bug:

Author: jgh
Date: Tue Mar 21 17:37:09 UTC 2017
New revision: 436623
URL: https://svnweb.freebsd.org/changeset/ports/436623

Log:
  - update to version 5.51
  - address issue with fortune [1]
  - address master_sites for distribution as main site is no longer operational
  - attach xorg library dependencies
  - attach license
  - adjust make_args for destdir support

  PR:		217182 [1]
  Reported by:>>>>Richard Narron <comet.berkeley@gmail.com>

Changes:
  head/x11/xlockmore/Makefile
  head/x11/xlockmore/distinfo
  head/x11/xlockmore/pkg-descr
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-03-21 17:41:46 UTC
A commit references this bug:

Author: jgh
Date: Tue Mar 21 17:40:47 UTC 2017
New revision: 436624
URL: https://svnweb.freebsd.org/changeset/ports/436624

Log:
  MFH: r436623

  - update to version 5.51
  - address issue with fortune [1]
  - address master_sites for distribution as main site is no longer operational
  - attach xorg library dependencies
  - attach license
  - adjust make_args for destdir support

  PR:		217182 [1]
  Reported by:>>>>Richard Narron <comet.berkeley@gmail.com>

  Approved by:  ports-secteam (with hat)

Changes:
_U  branches/2017Q1/
  branches/2017Q1/x11/xlockmore/Makefile
  branches/2017Q1/x11/xlockmore/distinfo
  branches/2017Q1/x11/xlockmore/pkg-descr
Comment 5 Jason Helfman freebsd_committer freebsd_triage 2017-03-21 17:43:09 UTC
Thanks for the report!
-jgh