Bug 217257 - devel/libc++ devel/libcxxrt: Remove, and clean out last dependencies
Summary: devel/libc++ devel/libcxxrt: Remove, and clean out last dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dimitry Andric
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-20 22:26 UTC by Dimitry Andric
Modified: 2017-02-24 21:10 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (mmokhi)
dim: exp-run?


Attachments
Delete devel/{libc++,libcxxrt}, update dependent ports and MOVED (31.55 KB, patch)
2017-02-20 22:26 UTC, Dimitry Andric
no flags Details | Diff
Delete devel/{libc++,libcxxrt}, update dependent ports and MOVED (32.40 KB, patch)
2017-02-23 20:07 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2017-02-20 22:26:53 UTC
Created attachment 180175 [details]
Delete devel/{libc++,libcxxrt}, update dependent ports and MOVED

I think the time has now come to finally get rid of the devel/libc++ and devel/libcxxrt ports, since these ports are rather outdated by now, and all supported versions of FreeBSD have libc++ and libcxxrt in the base system.

This diff:
* Deletes devel/libc++
* Deletes devel/libcxxrt (only consumer is devel/libc++)
* Removes devel/libc++ dependency from:
  - graphics/gnash
  - textproc/hs-double-conversion
  - x11-toolkits/hs-wxc
  - math/parmetis
* Add entries to MOVED.

An exp-run may be required for a sanity check.  I will leave that to portmgr@ :)
Comment 1 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-21 05:47:57 UTC
Well, I'm not sure why we should delete devel/libcxxrt.
AFAIK, it's updated on 20160529 (which easily can become newer).

But If you and portmgr@ have good reasons, I have no objections :-)
Comment 2 Dimitry Andric freebsd_committer freebsd_triage 2017-02-21 08:06:30 UTC
(In reply to Mahdi Mokhtari from comment #1)
> Well, I'm not sure why we should delete devel/libcxxrt.
> AFAIK, it's updated on 20160529 (which easily can become newer).
> 
> But If you and portmgr@ have good reasons, I have no objections :-)

devel/libcxxrt was added only for one reason: to support devel/libc++.  In turn, devel/libc++ was added only for the versions of FreeBSD that did not have libc++ in the base system, to support some ports that required C++11.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2017-02-22 09:58:51 UTC
Take for exp-run

A note:

- PORTREVISION will have to be bumped in parmetis and gnash

- the 2 ports will have to be removed from devel/Makefile
Comment 4 Dimitry Andric freebsd_committer freebsd_triage 2017-02-23 20:07:10 UTC
Created attachment 180249 [details]
Delete devel/{libc++,libcxxrt}, update dependent ports and MOVED

Patch updated:
* Update MOVED dates
* Update devel/Makefile
* Bump graphics/gnash, math/parmetis PORTREVISION
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2017-02-24 09:24:26 UTC
Exp-run looks fine.
Comment 6 Dimitry Andric freebsd_committer freebsd_triage 2017-02-24 17:39:16 UTC
Will it make sense to MFH this to the latest quarterly?
Comment 7 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-24 17:42:41 UTC
(In reply to Dimitry Andric from comment #6)
I think yes.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-02-24 17:57:45 UTC
A commit references this bug:

Author: dim
Date: Fri Feb 24 17:57:09 UTC 2017
New revision: 434738
URL: https://svnweb.freebsd.org/changeset/ports/434738

Log:
  Remove the devel/libc++ and devel/libcxxrt ports.

  Since all supported versions of FreeBSD now have libc++ and libcxxrt in
  the base system, and these ports were outdated, remove them, and update
  any ports that still depended on them:
  * graphics/gnash
  * textproc/hs-double-conversion
  * x11-toolkits/hs-wxc
  * math/parmetis

  Approved by:	portmgr (antoine)
  Exp-run by:	antoine
  PR:		217257
  MFH:		2017Q1

Changes:
  head/MOVED
  head/devel/Makefile
  head/devel/libc++/
  head/devel/libcxxrt/
  head/graphics/gnash/Makefile
  head/math/parmetis/Makefile
  head/textproc/hs-double-conversion/Makefile
  head/x11-toolkits/hs-wxc/Makefile
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-02-24 18:51:30 UTC
A commit references this bug:

Author: dim
Date: Fri Feb 24 18:50:36 UTC 2017
New revision: 434740
URL: https://svnweb.freebsd.org/changeset/ports/434740

Log:
  After r434738, also remove devel/xlocale, as it uses devel/libc++ as its
  MASTERDIR.  The port itself is not used by anything else.

  Approved by:	portmgr (antoine)
  PR:		217257

Changes:
  head/devel/Makefile
  head/devel/xlocale/
Comment 10 Dimitry Andric freebsd_committer freebsd_triage 2017-02-24 21:07:46 UTC
Just received mail from the indexing bot, that INDEX builds successfully again.
Comment 11 Mahdi Mokhtari freebsd_committer freebsd_triage 2017-02-24 21:10:19 UTC
(In reply to Dimitry Andric from comment #10)
Yeah.
Thanks, good job indeed __/|\__