Bug 217436 - A port without any OPTIONS_DEFINE won't package file in DOCSDIR or PORTEXAMPLESDIR if WITHOUT=DOCS/EXAMPLES
Summary: A port without any OPTIONS_DEFINE won't package file in DOCSDIR or PORTEXAMPL...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 20:59 UTC by John W. O'Brien
Modified: 2018-08-24 15:50 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2017-02-28 20:59:31 UTC 
Expected behavior
=================

A build with all options disabled will install plugins, templates, and tools.


Observed behavior
=================

With EXAMPLES disabled, the package contains only a README file.

With EXAMPLES and DOCS disabled, the package is empty.


How to reproduce
================

Build the port with EXAMPLES disabled.
Comment 1 John W. O'Brien 2017-02-28 21:23:50 UTC 
Also, it looks like the port needs

    OPTIONS_DEFINE= EXAMPLES DOCS

too. Otherwise, under poudriere

    OPTIONS_UNSET+= DOCS EXAMPLES
    sysutils_munin-contrib_SET+= EXAMPLES

still emits an empty package.
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2017-03-01 08:45:08 UTC 
Mmmm, fun.

The port does not have any option defined, because nothing is optional.

So, changing the options globally for the ports framework should not break it.

So, this is a framework bug, not a bug in this port.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-02 09:56:32 UTC 
A commit references this bug:

Author: mat
Date: Thu Mar  2 09:55:20 UTC 2017
New revision: 435222
URL: https://svnweb.freebsd.org/changeset/ports/435222

Log:
  Update to latest commit.

  Also, don't use PORTDOCS and PORTEXAMPLES, even if the port does not
  define both options, the files are not packaged if you set a global
  OPTIONS_UNSET.

  PR:		217436
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-contrib/Makefile
  head/sysutils/munin-contrib/distinfo