Bug 217671 - [patch] textproc/sdcv update to 0.5.0-beta2
Summary: [patch] textproc/sdcv update to 0.5.0-beta2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Eugene Grosbein
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-09 20:32 UTC by Anton Yuzhaninov
Modified: 2017-06-30 16:44 UTC (History)
1 user (show)

See Also:

Attachments
update to 0.5.0-beta2 (11.81 KB, patch)
2017-03-09 20:32 UTC, Anton Yuzhaninov 		no flags Details | Diff
update to 0.5.0-beta2 (12.09 KB, patch)
2017-03-12 15:58 UTC, Anton Yuzhaninov 		no flags Details | Diff
update to 0.5.0-beta2 (12.09 KB, patch)
2017-06-30 15:59 UTC, Anton Yuzhaninov 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Yuzhaninov 2017-03-09 20:32:17 UTC 
Created attachment 180680 [details]
update to 0.5.0-beta2

Please update sdcv to the latest version - 0.5.0-beta2
This version was released 4 years ago and there was no other (non beta) releases since then.

Because there no maintainer for this port, I'd like to become the one.

A lot of patches was removed, because corresponding issues were fixed by upstream.

New patch added: patch-src_libwrapper.cpp - fixes usage of SDCV_PAGER (less/more). This fix committed by upstream to git, but now new releases are planned.

There is overlinking with libintl, but I think it is a minor issue because sdcv port depends on glib20 and glib20 is always linked with libintl (no option to disable this dependency).
Comment 1 Anton Yuzhaninov 2017-03-11 05:39:48 UTC 
Port fails to build on FreeBSD 10.3, becuase sdcv's CMakeLists.txt fails to add ld flags for glib. There is no build error on FreeBSD 11 because -L${LOCALBASE}/lib added to LDFLAGS by /usr/ports/Mk/Uses/readline.mk

Easy workaround is to add:
LDFLAGS+=          -L${LOCALBASE}/lib
to port's Makefile, but I'm not sure that it is proper fix.
Comment 2 Anton Yuzhaninov 2017-03-12 15:58:50 UTC 
Created attachment 180748 [details]
update to 0.5.0-beta2

Updated path. Now builds on FreeBSD 10.3 too.
Comment 3 Anton Yuzhaninov 2017-03-15 17:37:11 UTC 
portlint: looks fine.
poudriere testport passed on 10.3-RELEASE i386/amd64 and 11.0-RELEASE i386/amd64/armv6.
Comment 4 Anton Yuzhaninov 2017-06-30 15:59:58 UTC 
Created attachment 183943 [details]
update to 0.5.0-beta2

Update patch after PORTREVISION bump in r444463 so it can apply clearly.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-06-30 16:43:04 UTC 
A commit references this bug:

Author: eugen
Date: Fri Jun 30 16:42:48 UTC 2017
New revision: 444770
URL: https://svnweb.freebsd.org/changeset/ports/444770

Log:
  Update textproc/sdcv to 0.5.0-beta2:

  - remove some patches that were integrated upstream and add new;
  - pass maintaintership to the submitter.

  PR:		217671
  Submitted by:	Anton Yuzhaninov <citrin@citrin.ru>
  Approved by:	vsevolod (mentor)

Changes:
  head/textproc/sdcv/Makefile
  head/textproc/sdcv/distinfo
  head/textproc/sdcv/files/patch-CMakeLists.txt
  head/textproc/sdcv/files/patch-src__lib__lib.cpp
  head/textproc/sdcv/files/patch-src__lib__mapfile.hpp
  head/textproc/sdcv/files/patch-src__libwrapper.cpp
  head/textproc/sdcv/files/patch-src__readline.cpp
  head/textproc/sdcv/files/patch-src__sdcv.cpp
  head/textproc/sdcv/files/patch-src__utils.cpp
  head/textproc/sdcv/files/patch-src_libwrapper.cpp
  head/textproc/sdcv/files/pkg-message.in
  head/textproc/sdcv/pkg-descr
  head/textproc/sdcv/pkg-plist
Comment 6 Eugene Grosbein freebsd_committer freebsd_triage 2017-06-30 16:44:14 UTC 
Committed, thanks!