Bug 217697 - databases/gtksql: Fix build (v0.4.5)
Summary: databases/gtksql: Fix build (v0.4.5)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-11 09:53 UTC by lightside
Modified: 2017-03-13 18:17 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 428908 revision) (2.93 KB, patch)
2017-03-11 09:53 UTC, lightside
no flags Details | Diff
Proposed patch (since 428908 revision) (2.93 KB, patch)
2017-03-11 10:31 UTC, lightside
no flags Details | Diff
Proposed patch (since 428908 revision) (2.91 KB, patch)
2017-03-11 10:54 UTC, lightside
no flags Details | Diff
Proposed patch (since 428908 revision) (2.94 KB, patch)
2017-03-11 19:53 UTC, lightside
no flags Details | Diff
Proposed patch (since 428908 revision) (3.01 KB, patch)
2017-03-12 06:56 UTC, lightside
no flags Details | Diff
Proposed patch (since 428908 revision) (2.99 KB, patch)
2017-03-13 06:17 UTC, lightside
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2017-03-11 09:53:10 UTC
Created attachment 180716 [details]
Proposed patch (since 428908 revision)

Patch to fix build of databases/gtksql port after x11-toolkits/scintilla update to v3.7.1.

- Bump PORTREVISION
- Add dependencies, which was found by stage-qa
- Add localbase to USES
- Replace portions of CPPFLAGS and LDFLAGS with sed patches for ${WRKSRC}/configure
- Add sed patch to rename some deprecated structure names after v3.7.1 update of x11-toolkits/scintilla
- Regenerate patches in files directory

The build was tested for FreeBSD 10.3 amd64 (native and with using poudriere; default options).
Comment 1 lightside 2017-03-11 09:56:27 UTC
Comment on attachment 180716 [details]
Proposed patch (since 428908 revision)

Proposed patch also works with x11-toolkits/scintilla update in bug 217693.
Comment 2 lightside 2017-03-11 10:31:37 UTC
Created attachment 180720 [details]
Proposed patch (since 428908 revision)

Paraphrase some comment.
Comment 3 lightside 2017-03-11 10:54:34 UTC
Created attachment 180722 [details]
Proposed patch (since 428908 revision)
Comment 4 lightside 2017-03-11 19:53:38 UTC
Created attachment 180731 [details]
Proposed patch (since 428908 revision)

Added correct patch.
Comment 5 lightside 2017-03-12 06:56:36 UTC
Created attachment 180739 [details]
Proposed patch (since 428908 revision)

Added sed patch to fix following compiler's warning, just in case:
-8<--
gtksql_query_scintilla.c:131:17: warning: implicitly declaring library function 'malloc' with type
      'void *(unsigned long)'
        tr.lpstrText = malloc((tr.chrg.cpMax - tr.chrg.cpMin) * 2);
                       ^
gtksql_query_scintilla.c:131:17: note: please include the header <stdlib.h> or explicitly provide a declaration for
      'malloc'
-->8-
Comment 6 lightside 2017-03-13 06:17:59 UTC
Created attachment 180761 [details]
Proposed patch (since 428908 revision)

Simplified sed patch a bit.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-03-13 18:17:33 UTC
A commit references this bug:

Author: krion
Date: Mon Mar 13 18:17:04 UTC 2017
New revision: 436103
URL: https://svnweb.freebsd.org/changeset/ports/436103

Log:
  - Fix build
  - Add new necessary dependencies
  - Replace portions of CPPFLAGS and LDFLAGS with sed patches for
    ${WRKSRC}/configure
  - Add sed patch to rename some deprecated structure names after
    v3.7.1 update of x11-toolkits/scintilla

  PR:		217697
  Submitted by:	lightside@gmx.com
  Approved by:	mat (mentor)
  Differential Revision: https://reviews.freebsd.org/D9974

Changes:
  head/databases/gtksql/Makefile
  head/databases/gtksql/files/patch-Makefile.in
  head/databases/gtksql/files/patch-po__Makefile.in.in