When repocopy was done from lang/python35 the BROKEN line was not removed. Python 3.6 has always been compatible with OpenSSL 1.1 and never suffered from this issue.
@Melvyn, could you provide a patch to the port with the proposed change as well as confirmation (and/or build/poudriere/qa log) that the port builds and packages correctly with the current version of openssl-devel.
3.6.1 is currently the only official release that builds and works correctly (EC certs broken in 3.6.0 and 3.5-) with OpenSSL 1.1.0. For details see bpo 29697 [1]. Don't have the time to dink around with poudriere, but I'll attach build log and patch shortly. [1] http://bugs.python.org/issue29697
Created attachment 182043 [details] Fix port
Created attachment 182044 [details] Buildlog
A commit references this bug: Author: sunpoet Date: Sat May 27 19:30:34 UTC 2017 New revision: 441865 URL: https://svnweb.freebsd.org/changeset/ports/441865 Log: Remove BROKEN_SSL PR: 217703 Submitted by: Melvyn Sopacua <m.r.sopacua@gmail.com> Changes: head/lang/python36/Makefile
Committed. Thanks!
Re-open pending MFH, as the quarterly port is presumably still affected (add comment and re-close if not)
Mat broke it again. Can you paste full buildlog and showconfig here, since obviously, it can be built with your commit reverted: tar -tf /var/packages/jobboo/All/python36-3.6.1_2.txz | grep '_ssl.so$' /usr/local/lib/python3.6/lib-dynload/_ssl.so
I did not such thing. I marked it as BROKEN because it was not building, with the error I gave. Here is the build log: https://pkg.absolight.fr/data/11amd64-pkgng-openssl-devel/20170608T121307Z/logs/errors/python36-3.6.1_2.log
@Melvyn This issue is/was to remove the BROKEN mark, which was (originally) completed (but still pending MFH). Please create a separate issue for the new failure with summary: lang/python36: Fails to package (ssl.so Undefined symbol "SSL_get0_next_proto_negotiated" If you could add this Issue URL to the new issue's "See Also" field, and add the failed build log as an attachment that would be great
No response on MFH, cancelling and closing
@Melvyn Please also CC the openssl and openssl-devel maintainers (if they are different)
A commit references this bug: Author: feld Date: Fri Jun 9 19:46:11 UTC 2017 New revision: 443039 URL: https://svnweb.freebsd.org/changeset/ports/443039 Log: MFH: r441865 Remove BROKEN_SSL PR: 217703 Submitted by: Melvyn Sopacua <m.r.sopacua@gmail.com> Changes: _U branches/2017Q2/
Update, for reference: This is an issue in Python upstream. Python uses #ifdef OPENSSL_NPN_NEGOTIATED to detect support. This is always defined in the OpenSSL 1.1 header (as opposed to OpenSSL 1.0.2 and earlier) and the symbols are guarded by #ifndef OPENSSL_NO_NEXTPROTONEG. The combo yields Python enabling support, but it not being available. This has been wrong from Python since the beginning, since the first commit introducing NPN already defined OPENSSL_NO_NEXTPROTONEG [1], but they've been able to get away with it till now. Of course, a variable saying something is not disabled, is a braindead concept in OpenSSL general source, as you can't detect if it's disabled if it is not born yet (in earlier versions). Working on a patch for upstream. @koobs I assume separate report if I'd like that patch included in the ports tree? [1] https://github.com/openssl/openssl/commit/68b33cc5c7aa1bb98e95bfb4b61c34192a7a50e3
(In reply to Melvyn Sopacua from comment #14) Yes please Melvyn. Please also cc python@ on creation of that issue, and feel free to add me (user: koobs) to the 'nosy' list in the python bug tracker.
MARKED AS SPAM