Bug 217706 - [New port] shells/zsh-antigen: A plugin manager for the Z shell, inspired by Vundle
Summary: [New port] shells/zsh-antigen: A plugin manager for the Z shell, inspired by ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-11 15:23 UTC by Victor
Modified: 2018-06-18 05:00 UTC (History)
3 users (show)

See Also:


Attachments
Subversion diff with zsh-antigen port (4.24 KB, patch)
2017-03-11 15:23 UTC, Victor
no flags Details | Diff
updated diff (4.24 KB, patch)
2017-03-12 01:28 UTC, Victor
no flags Details | Diff
Subversion diff with zsh-antigen port (corrected) (4.26 KB, patch)
2017-03-12 11:38 UTC, Victor
no flags Details | Diff
Subversion diff updated for 1.4.1 (4.26 KB, patch)
2017-04-21 15:29 UTC, Victor
no flags Details | Diff
Antigen v1.4.1 port (shar) (2.72 KB, text/plain)
2017-04-22 15:09 UTC, Victor
no flags Details
antigen v2.2.3 (shar) (2.23 KB, text/plain)
2018-06-14 22:11 UTC, Victor
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor 2017-03-11 15:23:12 UTC
Created attachment 180726 [details]
Subversion diff with zsh-antigen port

Antigen is a small set of functions that help you easily manage your shell (zsh) plugins, called bundles. The concept is pretty much the same as bundles in a typical vim+pathogen setup. Antigen is to zsh, what Vundle is to vim.

WWW: https://github.com/zsh-users/antigen/
Comment 1 Victor 2017-03-12 01:28:52 UTC
Created attachment 180734 [details]
updated diff

Removed cruft from the Makefile
Comment 2 Victor 2017-03-12 11:38:56 UTC
Created attachment 180742 [details]
Subversion diff with zsh-antigen port (corrected)

antigen requires git, added runtime dependency
Comment 3 Victor 2017-04-21 15:29:33 UTC
Created attachment 181978 [details]
Subversion diff updated for 1.4.1

Updated to current master branch from GitHub
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2017-04-22 12:05:54 UTC
Hi Victor,

Can you please resubmit as a shar?
Comment 5 Victor 2017-04-22 15:09:13 UTC
Created attachment 182002 [details]
Antigen v1.4.1 port (shar)

Resubmitted as shar
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-06-06 19:41:17 UTC
Sorry that it took more than a year to get any feedback on your submission!
Here are a couple of points that need to be fixed to get it into the ports
tree.

- The indentation is off.  Please remove one tab from each variable.
  Not everything has to be aligned to DISTVERSIONPREFIX.

Xdo-build:
X	# empty

NO_BUILD=	yes

XPORTNAME=		zsh-antigen
XGH_PROJECT=		antigen

Use this instead

PORTNAME=	antigen
PKGNAMEPREFIX=	zsh-

Xdo-extract:
X	${TAR} -C ${WRKDIR} -xf ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}
X	${CP} ${WRKDIR}/${GH_PROJECT}-${PORTVERSION}/bin/antigen.zsh ${WRKDIR}/${GH_PROJECT}-${PORTVERSION}/LICENSE ${WRKDIR}
X	${RM} -r ${WRKDIR}/${GH_PROJECT}-${PORTVERSION}

Remove.  You can install things directly from ${WRKSRC}.

- Remove pkg-message. You already have pkg-message.in

- Variable order is slightly wrong. See
  https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

- Update to the newest version please.  I don't think it makes sense to add
  a one year old version of antigen to the ports tree.

- Please confirm that this passes portlint and Poudriere testport.
Comment 7 Victor 2018-06-14 22:11:54 UTC
Created attachment 194261 [details]
antigen v2.2.3 (shar)

- Updated to antigen 2.2.3 (latest stable version)
- Made other fixes as suggested
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-06-18 05:00:04 UTC
A commit references this bug:

Author: tobik
Date: Mon Jun 18 04:59:41 UTC 2018
New revision: 472672
URL: https://svnweb.freebsd.org/changeset/ports/472672

Log:
  New port: shells/zsh-antigen

  Antigen is a small set of functions that help you easily manage
  your Z shell (zsh) plugins, called bundles.  The concept is pretty
  much the same as bundles in a typical vim+pathogen setup.  Antigen
  is to zsh, what Vundle is to vim.

  WWW: https://github.com/zsh-users/antigen

  PR:		217706
  Submitted by:	Victor <gudfitz@gmail.com>

Changes:
  head/shells/Makefile
  head/shells/zsh-antigen/
  head/shells/zsh-antigen/Makefile
  head/shells/zsh-antigen/distinfo
  head/shells/zsh-antigen/files/
  head/shells/zsh-antigen/files/pkg-message.in
  head/shells/zsh-antigen/pkg-descr