Bug 217714 - devel/poco: update to 1.7.8
Summary: devel/poco: update to 1.7.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-12 03:15 UTC by Henry Hu
Modified: 2017-03-14 10:35 UTC (History)
1 user (show)

See Also:

Attachments
update poco to 1.7.8 (2.97 KB, patch)
2017-03-12 03:15 UTC, Henry Hu 		no flags Details | Diff
poudriere log on 11/amd64 (573.03 KB, text/x-log)
2017-03-12 03:18 UTC, Henry Hu 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2017-03-12 03:15:09 UTC 
Created attachment 180735 [details]
update poco to 1.7.8

This patch updates devel/poco to 1.7.8.

I am interested in maintaining this port, so I changed the maintainer field.

A patch is added to fix build. The patch is already merged upstream, so it should be not needed in next release.
Comment 1 Henry Hu 2017-03-12 03:18:38 UTC 
Created attachment 180736 [details]
poudriere log on 11/amd64
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-03-12 15:27:32 UTC 
A commit references this bug:

Author: jrm
Date: Sun Mar 12 15:27:14 UTC 2017
New revision: 435993
URL: https://svnweb.freebsd.org/changeset/ports/435993

Log:
  devel/poco: update to 1.7.8

  Upstream release notes: https://pocoproject.org/blog/?p=1037

  PR:		217714
  Submitted by:	henry.hu.sh@gmail.com (new maintainer)
  Approved by:	swills (mentor, implicit)

Changes:
  head/devel/poco/Makefile
  head/devel/poco/distinfo
  head/devel/poco/files/patch-Net_src_SocketImpl.cpp
  head/devel/poco/pkg-plist
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2017-03-12 15:29:29 UTC 
Committed with a few tweaks.  Thanks.

FYI, the build fails in this version and the previous under 10/11 AMD64 when the TEST knob is on.
Comment 4 Henry Hu 2017-03-14 01:49:51 UTC 
(In reply to Joseph Mingrone from comment #3)
This problem is introduced by the patch from PR 207486, which fixes build on 9.3-i386 when using base gcc.
I just tried to build the port with patch removed, and it builds successfully on 10.3-i386 and 11.0-amd64 with TEST=on. Can I just remove the patch because 9.3 is no longer supported? Or shall I add a condition for 9.3+i386+gcc...
Comment 5 Joseph Mingrone freebsd_committer freebsd_triage 2017-03-14 02:15:58 UTC 
It's always nice to fix a problem by removing code.

There's no need to accommodate workarounds for 9.3 since it's EOL.

There were two patches introduced in PR 207486 (revision 409510).  The builds finish without both of them, so I will commit with them both removed.  Sound good?
Comment 6 Henry Hu 2017-03-14 05:00:06 UTC 
(In reply to Joseph Mingrone from comment #5)
Sure, I just completed poudriere run with both patch removed and they all finished. Please go ahead.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-03-14 10:35:31 UTC 
A commit references this bug:

Author: jrm
Date: Tue Mar 14 10:34:48 UTC 2017
New revision: 436145
URL: https://svnweb.freebsd.org/changeset/ports/436145

Log:
  devel/poco: Fix build when the TEST option is on by removing patches that
  were first added to fix build on 9.x.

  PR:		217714
  Reported by:	henry.hu.sh@gmail.com (maintainer)
  Approved by:	swills (mentor, implicit)

Changes:
  head/devel/poco/files/patch-Foundation_testsuite_src_StringTest.cpp
  head/devel/poco/files/patch-JSON_testsuite_src_JSONTest.cpp