Bug 217972 - [arm] comms/hamlib fails to detect C++ compiler
Summary: [arm] comms/hamlib fails to detect C++ compiler
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Diane Bruce
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-21 02:20 UTC by Kyle Evans
Modified: 2017-03-25 13:22 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)


Attachments
patch (890 bytes, patch)
2017-03-21 18:21 UTC, Mikael Urankar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2017-03-21 02:20:29 UTC
As in PR 196937, comms/hamlib fails to detect C++ compiler under emulation. A patch for this was introduced in r377901 and then removed in r398432, but I suspect it was still needed. I think the proper solution is to re-introduce the patch that was removed, but I can't properly test it myself because I'm failing to rebuild my arm.armv6 poudriere jail.
Comment 1 Kyle Evans freebsd_committer freebsd_triage 2017-03-21 02:27:59 UTC
CC'ing Mikael on this, since he submitted the original patch and is likely in a better position to test this (judging from past experience).
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2017-03-21 18:21:28 UTC
Created attachment 181033 [details]
patch

Yes it's still needed, patch attached
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-03-25 13:22:00 UTC
A commit references this bug:

Author: db
Date: Sat Mar 25 13:21:50 UTC 2017
New revision: 436901
URL: https://svnweb.freebsd.org/changeset/ports/436901

Log:
  As stated by Kyle Evans <bsdports@kyle-evans.net>
  "As in PR 196937, comms/hamlib fails to detect C++ compiler under emulation.
  A patch for this was introduced in r377901 and then removed in r398432,
  but I suspect it was still needed. I think the proper solution is to
  re-introduce the patch that was removed, but I can't properly test it
  myself because I'm failing to rebuild my arm.armv6 poudriere jail."

  re-introduce missing diff
  portlint again
  redo checksum

  PR:		ports/217972
  Reported by:	Kyle Evans <bsdports@kyle-evans.net>
  Reviewed by:	mikael.urankar@gmail.com

Changes:
  head/comms/hamlib/distinfo
  head/comms/hamlib/files/patch-bindings_Makefile.am
  head/comms/hamlib/files/patch-configure.ac