Bug 218226 - [CHANGE REQUEST] databases/postgis23: Missing dependency
Summary: [CHANGE REQUEST] databases/postgis23: Missing dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-30 14:30 UTC by Jason W. Bacon
Modified: 2017-05-15 16:14 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+

Attachments
Add postgresql contrib depend for Adress standard (631 bytes, patch)
2017-05-07 12:52 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
Add postgresql contrib depend for Adress standard (559 bytes, patch)
2017-05-15 05:03 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2017-03-30 14:30:30 UTC 
databases/postgresql93-contrib is not currently a dependency but is required for address normalization using the fuzztyrmatch function included in contrib.

Should this be added to RUN_DEPENDS?
Comment 1 Loïc Bartoletti freebsd_committer freebsd_triage 2017-05-07 07:06:16 UTC 
OK, I will add it with the new version of postgis23
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2017-05-07 12:52:25 UTC 
Created attachment 182358 [details]
Add postgresql contrib depend for Adress standard
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-07 14:37:06 UTC 
You should use WANT_PGSQL=contrib instead of hard-coded RUN_DEPENDS. Read Mk/Uses/pgsql.mk for details.
Comment 4 Loïc Bartoletti freebsd_committer freebsd_triage 2017-05-13 07:14:28 UTC 
(In reply to Po-Chuan Hsieh from comment #3)
You're right, but is not too big as a dependency to add it directly?
If I do ADDRSTD_WANT_PGSQL=contrib, it does not install contrib.
Comment 5 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-13 09:44:22 UTC 
You need ADDRSTD_VARS=WANT_PGSQL+=contrib because Mk/bsd.options.mk does not support <opt>_WANT_PGSQL.
Comment 6 Loïc Bartoletti freebsd_committer freebsd_triage 2017-05-15 05:01:05 UTC 
(In reply to Po-Chuan Hsieh from comment #5)
OK. Thanks!
Comment 7 Loïc Bartoletti freebsd_committer freebsd_triage 2017-05-15 05:03:30 UTC 
Created attachment 182607 [details]
Add postgresql contrib depend for Adress standard
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-05-15 15:54:11 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon May 15 15:53:48 UTC 2017
New revision: 440952
URL: https://svnweb.freebsd.org/changeset/ports/440952

Log:
  Add missing dependency

  - Bump PORTREVISION for dependency change

  PR:		218226
  Submitted by:	Jason Bacon <bacon4000@gmail.com>
  Approved by:	lbartoletti <lbartoletti@tuxfamily.org> (maintainer)

Changes:
  head/databases/postgis23/Makefile
Comment 9 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-05-15 16:14:40 UTC 
Committed. Thanks!