218328 – irc/irssi-xmpp build fails because of error: no member named 'use_ssl'

Bug 218328 - irc/irssi-xmpp build fails because of error: no member named 'use_ssl'

Summary: irc/irssi-xmpp build fails because of error: no member named 'use_ssl'

Status:	Closed DUPLICATE of bug 217916

Alias:	None

Product:	Ports & Packages
Classification:	Unclassified
Component:	Individual Port(s) (show other bugs)
Version:	Latest
Hardware:	Any Any

Importance:	--- Affects Only Me
Assignee:	Philippe Audeoud

URL:
Keywords:

Depends on:
Blocks:

Reported:	2017-04-03 11:53 UTC by p5B2EA84B3
Modified:	2017-06-06 15:05 UTC (History)
CC List:	4 users (show)

See Also:

Flags:	bugzilla: maintainer-feedback? (jadawin)

Attachments
Poudriere build log (17.61 KB, text/x-log) 2017-04-03 11:53 UTC, p5B2EA84B3	no flags	Details
irc/irssi-xmpp from cdidier (1.13 KB, patch) 2017-04-20 16:49 UTC, Anonymized Account	no flags	Details \| Diff
irc/irssi-xmpp from cdidier (228 bytes, text/plain) 2017-04-20 16:51 UTC, Anonymized Account	no flags	Details
irc/irssi-xmpp: portlint -AC (228 bytes, text/plain) 2017-04-20 16:52 UTC, Anonymized Account	no flags	Details
irc/irssi-xmpp: poudriere testport (46.98 KB, text/plain) 2017-04-20 16:53 UTC, Anonymized Account	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description p5B2EA84B3 2017-04-03 11:53:51 UTC

Created attachment 181425 [details]
Poudriere build log

=======================<phase: build          >============================
===>  Building for irssi-xmpp-0.53_1
core module:
cc  -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC   -I../../src/core  -I/usr/local/include/irssi  -I/usr/local/include/irssi/src  -I/usr/local/include/irssi/src/core  -I/usr/local/include/irssi/src/fe-common/core  -I/usr/local/include/irssi/src/fe-text  `pkg-config --cflags loudmouth-1.0` -o xmpp-commands.o -c xmpp-commands.c
cc  -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC   -I../../src/core  -I/usr/local/include/irssi  -I/usr/local/include/irssi/src  -I/usr/local/include/irssi/src/core  -I/usr/local/include/irssi/src/fe-common/core  -I/usr/local/include/irssi/src/fe-text  `pkg-config --cflags loudmouth-1.0` -o xmpp-core.o -c xmpp-core.c
cc  -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC   -I../../src/core  -I/usr/local/include/irssi  -I/usr/local/include/irssi/src  -I/usr/local/include/irssi/src/core  -I/usr/local/include/irssi/src/fe-common/core  -I/usr/local/include/irssi/src/fe-text  `pkg-config --cflags loudmouth-1.0` -o xmpp-queries.o -c xmpp-queries.c
cc  -O2 -pipe  -fstack-protector -fno-strict-aliasing -fPIC   -I../../src/core  -I/usr/local/include/irssi  -I/usr/local/include/irssi/src  -I/usr/local/include/irssi/src/core  -I/usr/local/include/irssi/src/fe-common/core  -I/usr/local/include/irssi/src/fe-text  `pkg-config --cflags loudmouth-1.0` -o xmpp-servers.o -c xmpp-servers.c
xmpp-servers.c:154:45: error: no member named 'use_ssl' in 'struct _XMPP_SERVER_CONNECT_REC'
                server->connrec->port = (server->connrec->use_ssl) ?
                                         ~~~~~~~~~~~~~~~  ^
xmpp-servers.c:338:23: error: no member named 'use_ssl' in 'struct _XMPP_SERVER_CONNECT_REC'
        if (server->connrec->use_ssl)
            ~~~~~~~~~~~~~~~  ^
xmpp-servers.c:473:23: error: no member named 'use_ssl' in 'struct _XMPP_SERVER_CONNECT_REC'
        if (server->connrec->use_ssl) {
            ~~~~~~~~~~~~~~~  ^
3 errors generated.


See attached full Poudriere buuild log

Comment 1 Walter Schwarzenfeld 2017-04-03 14:42:46 UTC

Found this:

https://github.com/cdidier/irssi-xmpp/issues/18#issuecomment-271335175

Comment 2 Walter Schwarzenfeld 2017-04-03 14:51:22 UTC

I don't know why he wants to change to tls.
If this not wanted (so if I am right) found another way:

--- src/core/xmpp-servers.h.orig        2017-04-03 13:16:00 UTC
+++ src/core/xmpp-servers.h
@@ -31,6 +31,7 @@ struct _XMPP_SERVER_CONNECT_REC {
        int              priority;
        char            *real_jid;
        char            *prompted_password;
+       gboolean        use_ssl;
 };

Comment 3 p5B2EA84B3 2017-04-05 09:45:06 UTC

As far as I remember irc/irssi-xmpp has correctly been switched to use tls as upstream irc/irssi moved to version 1.0.0. Then the irc/irssi FreeBSD-port was back downgraded for some time, so irssi-xmpp was changed back to use ssl again.

Now FreeBSD-port irc/irssi moved to 1.0.2, using tls and irssi-xmpp is still on ssl and needs to have tls.

Hope that this back and forth in the irc/irssi version makes clear, that irssi-xmpp needs to have tls.

Comment 4 Walter Schwarzenfeld 2017-04-05 10:32:12 UTC

The fux is in Bug 217916.

Comment 5 Anonymized Account freebsd_committer

2017-04-20 16:49:22 UTC

Created attachment 181943 [details]
irc/irssi-xmpp from cdidier

Comment 6 Anonymized Account freebsd_committer

2017-04-20 16:51:55 UTC

Created attachment 181944 [details]
irc/irssi-xmpp from cdidier

Oops.

Comment 7 Anonymized Account freebsd_committer

2017-04-20 16:52:20 UTC

Created attachment 181945 [details]
irc/irssi-xmpp: portlint -AC

Comment 8 Anonymized Account freebsd_committer

2017-04-20 16:53:06 UTC

Created attachment 181946 [details]
irc/irssi-xmpp: poudriere testport

Comment 9 Anonymized Account freebsd_committer

2017-04-20 16:56:14 UTC

Alternatively, this one doesn't change distfile: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217916/

Comment 10 Bernard Spil freebsd_committer

2017-04-20 18:56:07 UTC


*** This bug has been marked as a duplicate of bug 217916 ***

Comment 11 commit-hook freebsd_committer

2017-04-20 18:58:14 UTC

A commit references this bug:

Author: brnrd
Date: Thu Apr 20 18:57:34 UTC 2017
New revision: 438990
URL: https://svnweb.freebsd.org/changeset/ports/438990

Log:
  irc/irssi-xmpp: Fix build with irssi 1.0

   - Add patch from upstream

  PR:		217916, 218328
  Submitted by:	Thibault Jouan <tj+freebsd_ports@a13.fr>
  Approved by:	maintainer timeout
  Obtained from:	https://github.com/cdidier/irssi-xmpp/issues/18

Changes:
  head/irc/irssi-xmpp/files/
  head/irc/irssi-xmpp/files/patch-src_core_xmpp-servers.c

Comment 12 commit-hook freebsd_committer

2017-06-06 15:05:39 UTC

A commit references this bug:

Author: ler
Date: Tue Jun  6 15:05:16 UTC 2017
New revision: 442777
URL: https://svnweb.freebsd.org/changeset/ports/442777

Log:
  MFH: r438990 r439548

  Approved by: ports-secteam (blanket)

  irc/irssi-xmpp: Fix build with irssi 1.0

   - Add patch from upstream

  PR:		217916, 218328
  Submitted by:	Thibault Jouan <tj+freebsd_ports@a13.fr>
  Approved by:	maintainer timeout
  Obtained from:	https://github.com/cdidier/irssi-xmpp/issues/18

  irc/irssi-xmpp: Improve regex conformance

  PR:		218603
  Submitted by:	Kyle Evans <bsdports@kyle-evans.net>
  Approved by:	 jadwin (maintainer timeout), rene (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10524

Changes:
_U  branches/2017Q2/
  branches/2017Q2/irc/irssi-xmpp/Makefile
  branches/2017Q2/irc/irssi-xmpp/files/