Bug 218469 - devel/go-tools: avoid installing go libs or depending on packaged go libs
Summary: devel/go-tools: avoid installing go libs or depending on packaged go libs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords:
Depends on:
Blocks: 218290
  Show dependency treegraph
 
Reported: 2017-04-07 21:30 UTC by Steve Wills
Modified: 2017-07-08 02:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cs)


Attachments
patch for go-tools (26.62 KB, patch)
2017-04-07 21:30 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2017-04-07 21:30:58 UTC
Created attachment 181577 [details]
patch for go-tools

Almost every Go app wants a different version of any given lib. Forcing a Go app to use a different version than what upstream might have chosen is error prone at best. So, packaging Go libs doesn't make sense and I think we should remove the Go libs from ports.

To do that, we have to eliminate dependencies on go libs and avoid installing libs for packages which include stand alone binaries. This patch does that for devel/go-tools.

While here, it also strips the binaries. (I used to think this could cause issues, then I read:

https://honnef.co/posts/2016/10/go-and-strip/

which convinced me otherwise.)
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-08 02:21:05 UTC
A commit references this bug:

Author: swills
Date: Sat Jul  8 02:20:27 UTC 2017
New revision: 445292
URL: https://svnweb.freebsd.org/changeset/ports/445292

Log:
  devel/go-tools: avoid installing go libs or depending on packaged go libs

  PR:		218469
  Approved by:	cs (maintainer timeout, 3 months)

Changes:
  head/devel/go-tools/Makefile
  head/devel/go-tools/distinfo
  head/devel/go-tools/pkg-plist