Bug 218784 - databases/rocksdb: remove no-op, fix LITE cflags
Summary: databases/rocksdb: remove no-op, fix LITE cflags
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-20 23:12 UTC by David Thiel
Modified: 2017-04-23 17:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Remove CPPFLAGS, change to CFLAGS (612 bytes, patch)
2017-04-20 23:12 UTC, David Thiel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Thiel freebsd_committer freebsd_triage 2017-04-20 23:12:34 UTC 
Created attachment 181959 [details]
Remove CPPFLAGS, change to CFLAGS

After some functional testing, it looks like the current RocksDB isn't honoring CPPFLAGS. This makes the CPPFLAGS+= -DOS_FREEBSD a no-op, which is fine because cmake now defines that on its own. It also means that the CPPFLAGS+= -DROCKSDB_LITE=1 isn't getting honored.

This diff removes the first CPPFLAGS line, and changes the latter one to use CFLAGS instead, which correctly builds the lite version (verified by checking the symbols). Both regular and -lite poudriere correctly.
Comment 1 David Thiel freebsd_committer freebsd_triage 2017-04-20 23:16:42 UTC 
Also might want a PORTREVISION bump in addition, wasn't sure how you wanted to handle that, given the master/slave port situation.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-04-23 17:10:15 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Apr 23 17:09:22 UTC 2017
New revision: 439242
URL: https://svnweb.freebsd.org/changeset/ports/439242

Log:
  Use CFLAGS instead of CPPFLAGS

  - Bump PORTREVISION for package change

  PR:		218784
  Submitted by:	lx

Changes:
  head/databases/rocksdb/Makefile
Comment 3 Po-Chuan Hsieh freebsd_committer freebsd_triage 2017-04-23 17:21:07 UTC 
Committed. Thanks!