Bug 219010 - sysutils/fusefs-rar2fs: Update to 1.24.1
Summary: sysutils/fusefs-rar2fs: Update to 1.24.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-02 02:34 UTC by Niclas
Modified: 2017-08-03 19:41 UTC (History)
0 users

See Also:
jhale: maintainer-feedback+

Attachments
Update to 1.24.1 (831 bytes, patch)
2017-05-02 02:34 UTC, Niclas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Niclas 2017-05-02 02:34:17 UTC 
Created attachment 182239 [details]
Update to 1.24.1

Update rar2fs to 1.24.1

Release Notes

    Update for UnRAR source 5.5.3
    Fix an issue with volume consistency check
    Fix usage of VTYPE macro
    Fix a volume detection bug

Builds fine in 11.0/10.3 amd64 poudriere and works for me in 10.3 amd64.

I also saw that archivers/unrar was recently updated to 5.5.3. From rar2fs 1.24.0 and unrar 5.5.3 rar2fs has switched to using static linking of libunrar by default. Maybe a joint updating of sysutils/fusefs-rar2fs and archivers/libunrar5 would be desirable. If dynamic linking is preferred --disable-static-unrar could be used.
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2017-05-02 11:57:49 UTC 
(In reply to Niclas from comment #0)
I have an update for archivers/libunrar5 in testing now and I'll update rar2fs along side it so I don't have to bump PORTREVISION later.

rar2fs still links dynamically if the static library is not found in the unrar source directory which should be the case if building in a clean environment, but I'll specifically disable static linking in case someone is building from ports or there is a leftover. Thanks for the suggestion!
Comment 2 Niclas 2017-05-02 12:37:39 UTC 
(In reply to Jason E. Hale from comment #1)
Sounds great!

This might not be the correct place, but you mentioned during my last PR for fusefs-rar2fs that you didn't want to maintain a new port you don't use, and asked if I would be interested. I accepted and we agreed to change it with the next update I submitted. With the 1.24.0 update I was a bit slow on testing and writing a PR so you updated before I managed to. Would you still like someone to take over or are you fine doing it?
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-03 19:39:57 UTC 
A commit references this bug:

Author: jhale
Date: Thu Aug  3 19:39:46 UTC 2017
New revision: 447278
URL: https://svnweb.freebsd.org/changeset/ports/447278

Log:
  Update to 1.25.2
  Pass maintainership to submitter

  PR:		219010
  Submitted by:	Niclas Carlsson <n_carlsson@outlook.com>

Changes:
  head/sysutils/fusefs-rar2fs/Makefile
  head/sysutils/fusefs-rar2fs/distinfo
Comment 4 Jason E. Hale freebsd_committer freebsd_triage 2017-08-03 19:41:47 UTC 
I apologize for taking so long with this, but I updated to 1.25.2 and put you in as maintainer. Hopefully this is agreeable.