Bug 219325 - net/py-pcs: Limit to 2.x (Does not work with Python 3)
Summary: net/py-pcs: Limit to 2.x (Does not work with Python 3)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-05-16 10:29 UTC by Johannes Jost Meixner
Modified: 2017-08-19 12:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gnn)
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2017-05-16 10:29:18 UTC
Syntax used in net/py-pcs means it can't be installed on systems defaulting to Python 3.

Please modify USES= python to USES= python:2, and consider replacing pkg-plist with
USE_PYTHON+= autoplist
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-07-28 04:18:49 UTC
Throw back into bugs pool
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-08-19 12:42:20 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 12:41:44 UTC 2017
New revision: 448303
URL: https://svnweb.freebsd.org/changeset/ports/448303

Log:
  net/py-pcs: Limit to Python 2.7 (Does not support Python 3)

  This version (0.6) of the upstream package version does not appear to intend to,
  or explicitly support Python 3. It also currently fails to build with Python 3.x
  with a SyntaxError:

    SyntaxError: Missing parentheses in call to 'print'

  This change limits the USES=python:<version-spec> support declaration to 2.7
  accordingly.

  Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
  the version-specifier may change (be relaxed) upon future port/version updates,
  or at MAINTAINER's (also the package author) discretion to explicitly mark
  Python 3 as an intended supported version, *independent* to any build/run-time
  issues that may exist.

  While I'm here, pet portlint:

  - Strip shared libraries
  - Add LICENSE_FILE
  - Fix section order (*_DEPENDS)

  [1] https://github.com/gvnn3/PCS/pull/2

  PR:		219325
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)
  MFH:		2017Q3

Changes:
  head/net/py-pcs/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-19 12:45:25 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 12:44:42 UTC 2017
New revision: 448304
URL: https://svnweb.freebsd.org/changeset/ports/448304

Log:
  MFH: r448303

  net/py-pcs: Limit to Python 2.7 (Does not support Python 3)

  This version (0.6) of the upstream package version does not appear to intend to,
  or explicitly support Python 3. It also currently fails to build with Python 3.x
  with a SyntaxError:

    SyntaxError: Missing parentheses in call to 'print'

  This change limits the USES=python:<version-spec> support declaration to 2.7
  accordingly.

  Note: A closed upstream PR [1] mentions fixing tests for Python 3 in 2015, so
  the version-specifier may change (be relaxed) upon future port/version updates,
  or at MAINTAINER's (also the package author) discretion to explicitly mark
  Python 3 as an intended supported version, *independent* to any build/run-time
  issues that may exist.

  While I'm here, pet portlint:

  - Strip shared libraries
  - Add LICENSE_FILE
  - Fix section order (*_DEPENDS)

  [1] https://github.com/gvnn3/PCS/pull/2

  PR:		219325
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net/py-pcs/Makefile
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-19 12:47:53 UTC
Committed and merged, thank you for your report Johannes.

Additional Notes:

USES=python:<version-spec> is a 'declarative' version specifier, not an imperative one. It should reflect the 'intended' (ie 'supposed to') version support specification, according to upstream. 

It should not be used limit versions based on build-time or run-time failures, which may be transient. BROKEN/PYTHON_REL should be used for marking transient problems (independent to 'intended' support), if at all.

Regarding issue workflow:

 - maintainer timeouts normally can only apply to issues with patches (proposed changes timeout, not bug reports themselves). In this case the changes are all implicitly approved (blanket). I should have picked up on this earlier

 - When re-assigning issues, please make clear under what circumstances one is re-assigning, as 'Throw back into bugs pool' may not be clear to even developers.
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-08-19 12:52:32 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 12:52:23 UTC 2017
New revision: 448305
URL: https://svnweb.freebsd.org/changeset/ports/448305

Log:
  net/py-pcs: Limit USES=python (actually)

  Actually change the value of USES=python:<version-spec> that was
  supposed to land in ports r448303

  It was reverted during QA and the final diff was not reviewed prior to commit.

  Pointyhat me.

  PR:		219325
  Approved by:	portmgr (blanket)
  MFH:		2017Q3

Changes:
  head/net/py-pcs/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-08-19 12:55:36 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 12:54:35 UTC 2017
New revision: 448306
URL: https://svnweb.freebsd.org/changeset/ports/448306

Log:
  MFH: r448305

  net/py-pcs: Limit USES=python (actually)

  Actually change the value of USES=python:<version-spec> that was
  supposed to land in ports r448303

  It was reverted during QA and the final diff was not reviewed prior to commit.

  Pointyhat me.

  PR:		219325
  Approved by:	portmgr (blanket)

  Approved by:	portmgr (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net/py-pcs/Makefile