Bug 219793 - www/geneweb: Fix ocaml 4.xx compatibility issues
Summary: www/geneweb: Fix ocaml 4.xx compatibility issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-05 03:56 UTC by alex
Modified: 2018-05-07 13:26 UTC (History)
3 users (show)

See Also:

Attachments
Patch file for 6.08 -> 6.08_1 (2.69 KB, patch)
2017-06-05 03:56 UTC, alex 		koobs: maintainer-approval+
Details | Diff
Updated patch file: contains dependency for ocamlfind (2.81 KB, patch)
2017-11-17 03:30 UTC, alex 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description alex 2017-06-05 03:56:34 UTC 
Created attachment 183231 [details]
Patch file for 6.08 -> 6.08_1

Switch to use distrib-6-08-ocaml-4-xx branch of github.com/geneweb/geneweb, to address compatibility issues with OCaml 4.xx. Thanks to Cyril Servant for the good suggestion.

One file added: files/patch-configure
One file deleted: files/patch-tools__Makefile.inc.unix

Patch file is attached.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2017-08-18 18:09:31 UTC 
Build fails for me with:

===>  Configuring for geneweb-6.08_1
ocamlc ... OK
ocamlc version 4.02.3 >= 4.02 ... OK
camlp5 ... OK
OS type ... Unix
Could not find ocamlfind in the path.
You may need to update Makefile.ocaml by hand.
Comment 2 alex 2017-11-17 03:30:54 UTC 
Created attachment 188066 [details]
Updated patch file: contains dependency for ocamlfind

Apologies for the missing build dependency in the previous version of this patchfile.
I just today checked on the status of this PR and noticed the problem encountered by Steve Wills.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2018-05-07 12:58:56 UTC 
testbuild@work
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-05-07 13:26:27 UTC 
A commit references this bug:

Author: pi
Date: Mon May  7 13:26:24 UTC 2018
New revision: 469287
URL: https://svnweb.freebsd.org/changeset/ports/469287

Log:
  www/geneweb: change distsite to address compatibility issues with OCaml 4.xx

  - also: add ocamlfind dependency

  PR:		219793
  Submitted by:	Alex Stangl <alex@stangl.us> (maintainer)
  Reviewed by:	swills

Changes:
  head/www/geneweb/Makefile
  head/www/geneweb/distinfo
  head/www/geneweb/files/patch-configure
  head/www/geneweb/files/patch-tools__Makefile.inc.unix
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2018-05-07 13:26:47 UTC 
Committed, thanks!