Bug 219808 - audio/mp3blaster: Update to 3.2.6, fix SDL, NAS, and ESOUND options
Summary: audio/mp3blaster: Update to 3.2.6, fix SDL, NAS, and ESOUND options
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Roman Bogorodskiy
URL: https://reviews.freebsd.org/D11076
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-06-06 00:15 UTC by Tobias Kortkamp
Modified: 2017-06-06 21:21 UTC (History)
1 user (show)

See Also:
novel: maintainer-feedback+

Attachments
mp3blaster.diff (5.33 KB, patch)
2017-06-06 00:15 UTC, Tobias Kortkamp 		tobik: maintainer-approval? (novel)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2017-06-06 00:15:23 UTC 
Update to 3.2.6

While here:
- Add license
- Add missing SDL option to OPTIONS_DEFINE
- Fix ESOUND option
- Fix build of NAS option with clang < 4.0
- The configure script says this
  configure: WARNING: unrecognized options: --with-cxxflags
  so remove it from CONFIGURE_ARGS
- Regenerate patches

Changes:	http://www.mp3blaster.org/2017/05/its-only-been-8-years.html

Poudriere 11.0/amd64 test builds are fine
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-06-06 00:15:48 UTC 
Created attachment 183248 [details]
mp3blaster.diff
Comment 2 Roman Bogorodskiy freebsd_committer freebsd_triage 2017-06-06 16:02:34 UTC 
Thanks for the patch, it looks good to me. You're welcome to commit it, or I can do it myself if you want.
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2017-06-06 19:23:55 UTC 
Thanks, I'll commit it :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-06-06 21:21:33 UTC 
A commit references this bug:

Author: tobik
Date: Tue Jun  6 21:20:56 UTC 2017
New revision: 442807
URL: https://svnweb.freebsd.org/changeset/ports/442807

Log:
  Update to 3.2.6

  While here:
  - Add license
  - Add the missing SDL option to OPTIONS_DEFINE
  - Fix ESOUND option
  - Fix build of NAS option with Clang < 4.0
  - The configure script says this
    configure: WARNING: unrecognized options: --with-cxxflags
    so remove it from CONFIGURE_ARGS
  - Regenerate patches

  Changes:	http://www.mp3blaster.org/2017/05/its-only-been-8-years.html
  PR:		219808
  Approved by:	lme (mentor), novel (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D11076

Changes:
  head/audio/mp3blaster/Makefile
  head/audio/mp3blaster/distinfo
  head/audio/mp3blaster/files/patch-mpegsound_nasplayer.cc
  head/audio/mp3blaster/files/patch-src__global.cc
  head/audio/mp3blaster/files/patch-src__main.cc
  head/audio/mp3blaster/files/patch-src_main.cc