Bug 219824 - www/uzbl: Fix distinfo checksum
Summary: www/uzbl: Fix distinfo checksum
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-06-06 15:20 UTC by Johannes Jost Meixner
Modified: 2017-06-20 16:30 UTC (History)
2 users (show)

See Also:
aehlig: maintainer-feedback+
koobs: merge-quarterly?


Attachments
update checksum (725 bytes, patch)
2017-06-06 15:21 UTC, Johannes Jost Meixner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2017-06-06 15:20:15 UTC

    
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-06-06 15:21:00 UTC
Created attachment 183266 [details]
update checksum
Comment 2 Klaus Aehlig 2017-06-06 16:57:48 UTC
Thanks for noting that the upstream tar ball has been re-rolled!

The content change is fortunately not very relevant: only one more hex digit is included in the embedded source git hash. So please go ahead and commit your attached patch. Thank you very much.
Comment 3 Jochen Neumeister freebsd_committer freebsd_triage 2017-06-15 11:37:40 UTC
review: https://reviews.freebsd.org/D11214
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2017-06-17 08:24:06 UTC
Please explain what upstream have change, thats quiet imported to explain why it was rerolled.
Comment 5 Klaus Aehlig 2017-06-17 08:46:09 UTC
Let me reexplain, what I already did explain in comment #2.

The difference between the old and the new tar ball is literally one additional hex digit in the embedded git version. In other words

$ diff -ruN old new
diff -ruN old/uzbl-0.9.1/misc/hash.sh new/uzbl-0.9.1/misc/hash.sh
--- old/uzbl-0.9.1/misc/hash.sh 2016-10-27 09:57:35.000000000 +0200
+++ new/uzbl-0.9.1/misc/hash.sh 2016-10-27 09:57:35.000000000 +0200
@@ -15,7 +15,7 @@
     if [ -n "$tarball_tag" ]; then
         echo "$tarball_tag"
     else
-        echo '981a45e'
+        echo '981a45e8'
     fi
 else
     echo >&2 "Commit hash detection fail. Dear packager, please figure out what goes wrong or get in touch with us"
$

Such rerolls happen whenever github decides to change how long a prefix of a git hash is a good version name for a commit. Because the actual upstream source, https://github.com/uzbl/uzbl/blob/981a45e848c779a3f7b49ce157e3f6df2f561099/misc/hash.sh, of course, only contains a place holder for the hash at that place that automatically gets replaced when github constructs the tarball for a given release commit.

And the keyword-expansion scheme has changed (let's take 8 instead of 7 hex digits to name a git commit), hence all tarballs containing this keyword expansion have changed. But it certainly is not a functional change of the resulting package.
Comment 6 Jochen Neumeister freebsd_committer freebsd_triage 2017-06-17 08:59:27 UTC
(In reply to Klaus Aehlig from comment #5)

ah, i see, thanks ...

sorry for the delay
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-06-20 16:29:41 UTC
A commit references this bug:

Author: joneum
Date: Tue Jun 20 16:29:06 UTC 2017
New revision: 443992
URL: https://svnweb.freebsd.org/changeset/ports/443992

Log:
  - Upstream rerolled the distfiles
    *The difference between the old and the new tar ball is literally
     one additional hex digit in the embedded git version

  PR:		219824
  Reported by:	xmj
  Approved by:	Klaus Aehlig <aehlig at linta.de> (maintainer) xxx (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11214

Changes:
  head/www/uzbl/Makefile
  head/www/uzbl/distinfo
Comment 8 Jochen Neumeister freebsd_committer freebsd_triage 2017-06-20 16:30:13 UTC
Committed, thanks :-)