Bug 220572 - x11-wm/cde cleanups
Summary: x11-wm/cde cleanups
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-08 21:26 UTC by Pedro F. Giffuni
Modified: 2018-12-09 13:52 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (crees)


Attachments
Minor changes (774 bytes, patch)
2017-07-08 21:26 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2017-07-08 21:26:18 UTC
Created attachment 184194 [details]
Minor changes

- Add ksh93 as a run dependency.
- Fix location of Xsession file in pkg-message.

It still doesn't work :(  ... I see a black screen and terminal but nothing else happens.
Comment 1 Chris Rees freebsd_committer freebsd_triage 2017-07-09 13:35:42 UTC
Hey,

Do you have a symlink /usr/dt -> /usr/local/dt? 

Did you start the service (it's created by the service) 

Not sure the Korn shell dependency is necessary as it bundles one, but the smylink is necessary.

Chris
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-07-09 16:26:35 UTC
(In reply to Chris Rees from comment #1)
Hmm ...
I had the service but I missed the symlink.

Thanks.
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-07-09 17:23:09 UTC
(In reply to Pedro F. Giffuni from comment #2)

BTW ... there is probably some way to add the symlink through the pkg-plist.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2017-07-09 19:18:15 UTC
Symlink should be created by the service!  Line 27:

https://svnweb.freebsd.org/ports/head/x11-wm/cde/files/dtspc.in?revision=442032&view=markup
Comment 5 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-07-09 21:22:48 UTC
(In reply to Chris Rees from comment #4)
I don't know why that didn't work:

more /etc/rc.conf
# For CDE
rpcbind_enable="YES"
dtspc_enable="YES"
dtcms_enable="YES"
...

but IMHO it is something that should be done by the pkg(1) instead.
Comment 6 Chris Rees freebsd_committer freebsd_triage 2017-07-09 21:28:06 UTC
I would disagree, as touching stuff outside PREFIX shouldn't really be done.

Are you certain you had the service started? I don't understand why it wouldn't work for you.  Hopefully it's a short term issue anyway, as someone has worked on one where it's been properly moved inside PREFIX (clearly has worked out the evil imake stuff carefully)
Comment 7 Pedro F. Giffuni freebsd_committer freebsd_triage 2017-07-09 21:34:22 UTC
(In reply to Chris Rees from comment #6)

Services shouldn't go on creating links to the root file system either, in fact they should run without privileges when possible. A post-install script can do it. I think perl does it.

I do have the services running but there was no symlink. This was a very transitory experiment though... I am back to running kdm (KDE).
Comment 8 Chris Rees freebsd_committer freebsd_triage 2017-08-29 09:42:07 UTC
Yes, OK.  I'm modifying it to package the links.  Will go in next commit.
Comment 9 Walter Schwarzenfeld freebsd_triage 2018-01-19 07:00:15 UTC
Any news here?
Comment 10 Chris Rees freebsd_committer freebsd_triage 2018-11-04 21:40:31 UTC
So, I've updated CDE to 2.3.0 and incorporated the fixes here and taken more of Mikael's approach to the port in the first place.  It builds fine for me but is playing up over VNC-- my desktop is kinda broken at the moment so I can't run test it that well.

https://www.bayofrum.net/~crees/scratch/cde-2.3.0.tar.bz2

Would you like to have a go with this?

Mikael, would you like maintainership of this given you've clearly got a better handle on the code than me?

Chris
Comment 11 Mikael Urankar freebsd_committer freebsd_triage 2018-11-05 17:13:31 UTC
(In reply to Chris Rees from comment #10)
Sorry but I don't have time these days to maintain such complicated port.
Comment 12 commit-hook freebsd_committer freebsd_triage 2018-11-05 18:50:12 UTC
A commit references this bug:

Author: crees
Date: Mon Nov  5 18:49:27 UTC 2018
New revision: 484207
URL: https://svnweb.freebsd.org/changeset/ports/484207

Log:
  Update to 2.3.0

  Move to more correct x11 category

  Unbreak

  Incorporate changes and improvements made by Mikael Urankar

  PR:		ports/221102
  Submitted by:	mikael.urankar@gmail.com

  Various other cleanups; correct pkg-message and add ksh dependency

  PR:		ports/220572
  Submitted by:	pfg

Changes:
  head/MOVED
  head/x11/Makefile
  head/x11/cde/
  head/x11/cde/Makefile
  head/x11/cde/distinfo
  head/x11/cde/files/patch-admin_IntegTools_dbTools_installCDE
  head/x11/cde/files/patch-admin_IntegTools_post__install_freebsd_configMin.src
  head/x11/cde/files/patch-admin_IntegTools_post__install_freebsd_configRun.src
  head/x11/cde/files/patch-admin_IntegTools_post__install_freebsd_configShlibs.src
  head/x11/cde/files/patch-config_cf_Imake.cf
  head/x11/cde/files/patch-config_cf_Imake.rules
  head/x11/cde/files/patch-lib_tt_lib_util_tt__file__system.C
  head/x11/cde/files/pkg-message.in
  head/x11/cde/pkg-plist
  head/x11-wm/Makefile
  head/x11-wm/cde/
Comment 13 Chris Rees freebsd_committer freebsd_triage 2018-11-05 18:51:23 UTC
Committed as part of update.  Thanks for the help with it all Pedro and Mikael.
Comment 14 commit-hook freebsd_committer freebsd_triage 2018-12-09 13:52:13 UTC
A commit references this bug:

Author: crees
Date: Sun Dec  9 13:51:20 UTC 2018
New revision: 487047
URL: https://svnweb.freebsd.org/changeset/ports/487047

Log:
  MFH 484207 (partial)

  Update to 2.3.0

  Unbreak

  Incorporate changes and improvements made by Mikael Urankar

  PR:		ports/221102
  Submitted by:	mikael.urankar@gmail.com

  Various other cleanups; correct pkg-message and add ksh dependency

  PR:		ports/220572
  Submitted by:	pfg

  NOT MERGED:
  Move to more correct x11 category
  Approved by:	portmgr (implicit; unbreaking)

Changes:
  branches/2018Q4/x11-wm/cde/Makefile
  branches/2018Q4/x11-wm/cde/distinfo
  branches/2018Q4/x11-wm/cde/files/patch-admin_IntegTools_dbTools_installCDE
  branches/2018Q4/x11-wm/cde/files/patch-admin_IntegTools_post__install_freebsd_configMin.src
  branches/2018Q4/x11-wm/cde/files/patch-admin_IntegTools_post__install_freebsd_configRun.src
  branches/2018Q4/x11-wm/cde/files/patch-admin_IntegTools_post__install_freebsd_configShlibs.src
  branches/2018Q4/x11-wm/cde/files/patch-config_cf_Imake.cf
  branches/2018Q4/x11-wm/cde/files/patch-config_cf_Imake.rules
  branches/2018Q4/x11-wm/cde/files/patch-lib_tt_lib_util_tt__file__system.C
  branches/2018Q4/x11-wm/cde/files/pkg-message.in
  branches/2018Q4/x11-wm/cde/pkg-plist