Bug 220614 - x11/lightdm-gtk-greeter: allow locale selection, fix config file handling
Summary: x11/lightdm-gtk-greeter: allow locale selection, fix config file handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-10 21:56 UTC by Pawel Pekala
Modified: 2017-07-24 13:55 UTC (History)
0 users

See Also:
woodsb02: maintainer-feedback+
woodsb02: merge-quarterly+

Attachments
locale-fix (5.26 KB, patch)
2017-07-10 21:56 UTC, Pawel Pekala 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2017-07-10 21:56:00 UTC 
Created attachment 184243 [details]
locale-fix

- Allow locale selection on login screen, first lightdm must be patched
  to correctly detect utf8 locales, on FreeBSD they have UTF-8 suffix not
  utf8 like on Linux systems. Then we have to use locales codes in
  language menuitem as FreeBSD don't have support for locale naming - missing
  _NL_IDENTIFICATION_LANGUAGE implementation

- Use @sample for lightdm-gtk-greeter config file so it's not overwritten on
  reinstall / upgrade
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-24 12:48:36 UTC 
A commit references this bug:

Author: woodsb02
Date: Mon Jul 24 12:47:46 UTC 2017
New revision: 446523
URL: https://svnweb.freebsd.org/changeset/ports/446523

Log:
  x11/lightdm: Fix locale selection

  - Allow locale selection on login screen. First, lightdm must be patched
    to correctly detect utf8 locales, which have a UTF-8 suffix on FreeBSD
    instead of utf8 like on Linux systems. Secondly, we have to use locale
    codes in the language menuitem as FreeBSD doesn't have support for
    locale naming (missing _NL_IDENTIFICATION_LANGUAGE implementation).

  - Use @sample for lightdm-gtk-greeter config file to prevent it from
    being overwritten when the package is reinstalled / upgraded.

  PR:		220614
  Submitted by:	pawel
  MFH:		2017Q3

Changes:
  head/x11/lightdm/Makefile
  head/x11/lightdm/files/patch-liblightdm-gobject_language.c
  head/x11/lightdm-gtk-greeter/Makefile
  head/x11/lightdm-gtk-greeter/files/
  head/x11/lightdm-gtk-greeter/files/patch-src_lightdm-gtk-greeter.c
  head/x11/lightdm-gtk-greeter/pkg-plist
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-07-24 12:56:44 UTC 
A commit references this bug:

Author: woodsb02
Date: Mon Jul 24 12:56:08 UTC 2017
New revision: 446525
URL: https://svnweb.freebsd.org/changeset/ports/446525

Log:
  MFH: r446523

  x11/lightdm: Fix locale selection

  - Allow locale selection on login screen. First, lightdm must be patched
    to correctly detect utf8 locales, which have a UTF-8 suffix on FreeBSD
    instead of utf8 like on Linux systems. Secondly, we have to use locale
    codes in the language menuitem as FreeBSD doesn't have support for
    locale naming (missing _NL_IDENTIFICATION_LANGUAGE implementation).

  - Use @sample for lightdm-gtk-greeter config file to prevent it from
    being overwritten when the package is reinstalled / upgraded.

  PR:		220614
  Submitted by:	pawel

  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q3/
  branches/2017Q3/x11/lightdm/Makefile
  branches/2017Q3/x11/lightdm/files/patch-liblightdm-gobject_language.c
  branches/2017Q3/x11/lightdm-gtk-greeter/Makefile
  branches/2017Q3/x11/lightdm-gtk-greeter/files/
  branches/2017Q3/x11/lightdm-gtk-greeter/pkg-plist
Comment 3 Ben Woods freebsd_committer freebsd_triage 2017-07-24 13:55:49 UTC 
Committed - thanks for this pawel!