Bug 220689 - databases/mantis Port out of date because new release versions have not been picked up by portscout
Summary: databases/mantis Port out of date because new release versions have not been ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-12 17:41 UTC by michaelp
Modified: 2017-08-22 15:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (dvl)


Attachments
update to 2.5.1 + plugins (179.84 KB, patch)
2017-07-25 15:30 UTC, Ivan Rozhuk
no flags Details | Diff
update to 2.5.1 + plugins (177.88 KB, patch)
2017-07-26 11:59 UTC, Ivan Rozhuk
no flags Details | Diff
update to 2.5.1 + plugins (94.21 KB, patch)
2017-07-26 14:19 UTC, Ivan Rozhuk
no flags Details | Diff
fix options selection (94.21 KB, patch)
2017-08-20 22:28 UTC, Ivan Rozhuk
no flags Details | Diff
applies cleanly and builds - based on previous patch (106.65 KB, patch)
2017-08-21 12:40 UTC, Dan Langille
no flags Details | Diff
includes patch dropped in previous attempt (107.79 KB, patch)
2017-08-21 20:38 UTC, Dan Langille
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michaelp 2017-07-12 17:41:28 UTC
The port databases/mantis is wildly out of date. While the bug reporting guidlines state not to raise bug reports for this I feel it is warranted as for some reason portscout is not picking up on the new versions.

https://portscout.freebsd.org/ports@freebsd.org.html 
Doesn't list the port as out of date and the port revision is 1.2.19. However visiting www.mantisbt.org shows the current version as 2.5.1. 

I think the fact that portscout hasn't picked up the version update also means that the port vulnerability checker isn't picking up the fact that the current port revision has many uncorrected security defects. 5 were fixed in 1.2.20 and there have been may more raised against the 1.3.x and 2.x.x releases which could easily also apply to 1.2.19.
Comment 1 Dan Langille freebsd_committer freebsd_triage 2017-07-14 14:36:49 UTC
I no longer use mantis.

I am happy to give up maintainership and/or commit PRs submitted to update the port.

As usual, it's a matter of time resources.
Comment 2 michaelp 2017-07-14 14:50:56 UTC
That's cool. I'll see if I can find some time to submit an updated package for a more up to date version as we do use it here.

Is it still worth working out why the portcout tool isn't picking up the version announcements?
Comment 3 Dan Langille freebsd_committer freebsd_triage 2017-07-14 14:52:12 UTC
I would wait until after the port is updated.
Comment 4 Ivan Rozhuk 2017-07-25 15:30:00 UTC
Created attachment 184703 [details]
update to 2.5.1 + plugins

Need q-a and feedback.
Comment 5 Ivan Rozhuk 2017-07-25 15:33:25 UTC
(In reply to Dan Langille from comment #1)

What bug tracker do you use?
Comment 6 michaelp 2017-07-25 16:18:37 UTC
I have several databases that are currently running 1.2.19 from the port so once I work out which plugins we need I can test this on our test deployment jail. It might take a while as although I'm the system admin I'm not the mantis db admin so I might need a little time with them to understand what bits of mantis we do actually use so I can configure the port appropriately.
Comment 7 Dan Langille freebsd_committer freebsd_triage 2017-07-25 18:11:44 UTC
(In reply to rozhuk.im from comment #5)
I'm not using a bug tracker at home now.
Comment 8 Ivan Rozhuk 2017-07-26 11:59:11 UTC
Created attachment 184719 [details]
update to 2.5.1 + plugins

add missing libs, remove unneeded files
Comment 9 Ivan Rozhuk 2017-07-26 14:19:51 UTC
Created attachment 184727 [details]
update to 2.5.1 + plugins

Remove all plugns than compatible only with 1.x.

If some one want to use 1.x then easy way to start - modify prev attachment to use 1.x core and remove from there 2.x only plugins.
Comment 10 Dan Langille freebsd_committer freebsd_triage 2017-08-06 21:48:12 UTC
I tried the attached patch.  It fails.  Details at https://services.unixathome.org/poudriere/data/110amd64-working/2017-08-06_21h41m41s/logs/errors/mantis-2.5.1.log

summary:

====> You must check at least one option in the PLUGINS multi

I'm out of time. If you can fix it, I'll try again.
Comment 11 Ivan Rozhuk 2017-08-20 22:28:48 UTC
Created attachment 185616 [details]
fix options selection
Comment 12 Dan Langille freebsd_committer freebsd_triage 2017-08-21 12:26:52 UTC
Thank you.

Are you sure that databases/mantis/files/patch-api_rest_swagger_index.php is required?

That patch does not apply cleanly, and looking at the vendor code, it seems fine.
Comment 13 Dan Langille freebsd_committer freebsd_triage 2017-08-21 12:40:14 UTC
Created attachment 185639 [details]
applies cleanly and builds - based on previous patch

applies cleanly and builds
Comment 14 Dan Langille freebsd_committer freebsd_triage 2017-08-21 12:41:33 UTC
If you like the most recently submitted patch, I'll commit it.
Comment 15 Ivan Rozhuk 2017-08-21 20:15:18 UTC
(In reply to Dan Langille from comment #12)
Yes, it required.
Without it some script will be loaded from external source.

I install matis in few different places with my patch, can you provide more information about failures?
Comment 16 Dan Langille freebsd_committer freebsd_triage 2017-08-21 20:38:30 UTC
Created attachment 185654 [details]
includes patch dropped in previous attempt

(In reply to rozhuk.im from comment #15)
I have no idea why I thought that.  Here is a new patch from my working directory.  It is also vastly different from what I had before. I have no explanation.
Comment 17 Ivan Rozhuk 2017-08-22 09:39:30 UTC
(In reply to Dan Langille from comment #16)

Looks ok, but in my patch I remove tests and some crap by hands to not install it.
Comment 18 Dan Langille freebsd_committer freebsd_triage 2017-08-22 12:06:38 UTC
(In reply to rozhuk.im from comment #17)
Would you like to become the maintainer for this port?
Comment 19 Ivan Rozhuk 2017-08-22 14:35:42 UTC
(In reply to Dan Langille from comment #18)
No, thanks.
Comment 20 commit-hook freebsd_committer freebsd_triage 2017-08-22 14:55:48 UTC
A commit references this bug:

Author: dvl
Date: Tue Aug 22 14:55:13 UTC 2017
New revision: 448537
URL: https://svnweb.freebsd.org/changeset/ports/448537

Log:
  Upgrade to 2.5.1

  give up MAINTAINER

  PR:	220689

Changes:
  head/databases/mantis/Makefile
  head/databases/mantis/distinfo
  head/databases/mantis/files/patch-api_rest_swagger_index.php
  head/databases/mantis/files/patch-config__defaults__inc.php
  head/databases/mantis/pkg-plist
Comment 21 Dan Langille freebsd_committer freebsd_triage 2017-08-22 15:05:05 UTC
Thank you all.