Bug 221009 - net-mgmt/smokeping: rc script does not wait for smokeping to finish
Summary: net-mgmt/smokeping: rc script does not wait for smokeping to finish
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rodrigo Osorio
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2017-07-25 21:34 UTC by Kajetan Staszkiewicz
Modified: 2017-07-31 22:16 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)
koobs: merge-quarterly?

Attachments
Wait for smokeping to terminate (257 bytes, patch)
2017-07-25 21:34 UTC, Kajetan Staszkiewicz 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kajetan Staszkiewicz 2017-07-25 21:34:16 UTC 
Created attachment 184708 [details]
Wait for smokeping to terminate

With smokeping busy pinging a few hundred hosts it will often not terminate immediately when asked to do so. Therefore restarting is often impossible because the old smokeping still runs when a new one tries to start.

I think a simple `wait_for_pids` should do the trick. Please see the attached diff.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-31 22:15:41 UTC 
A commit references this bug:

Author: rodrigo
Date: Mon Jul 31 22:15:04 UTC 2017
New revision: 447003
URL: https://svnweb.freebsd.org/changeset/ports/447003

Log:
  Add a wait_for_pids at the end of the rc script stop function, waiting for the
  daemon to stops. With smokeping busy pinging a few hundred hosts it often occurs
  that the daemon stops after the rc call completion failing a restart.
  Bump PORTREVISION.

  PR:		221009
  Submitted by:	vegeta@tuxpowered.net

Changes:
  head/net-mgmt/smokeping/Makefile
  head/net-mgmt/smokeping/files/smokeping.in
Comment 2 Rodrigo Osorio freebsd_committer freebsd_triage 2017-07-31 22:16:40 UTC 
Committed, thanks