Bug 221025 - [exp-run] Update devel/gdb to 8.0
Summary: [exp-run] Update devel/gdb to 8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Baldwin
URL: https://reviews.freebsd.org/D11465
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-26 14:57 UTC by John Baldwin
Modified: 2017-07-28 21:21 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2017-07-26 14:57:52 UTC
The reason we are asking for an exp-run as it seems that clang in 10.3 release may crash due to an internal clang bug when building gdb 8.0 (which is now C++11 code).  The maintainer (Luca) has reproduced a crash in clang 3.9.1 twice on two separate machines.  When I built 8.0 on amd64 and i386 10.3 release jails I didn't see the crash.  There aren't any ports that depend on devel/gdb, so you could just do a limited build of devel/gdb to see if it works or not on your end.  The actual diff is in the phab URL.

Thanks!
Comment 2 luca.pizzamiglio 2017-07-27 10:51:28 UTC
Using compiler:c++14-lang instead of compiler:c++11-lib in the USES line solves the issue on FreeBSD 10.3, forcing to use a more recent clang version if the installed one is older than 3.5

No extra clang is installed on FreeBSD 11.x

I've added the same comment on the review as well
Comment 3 John Baldwin freebsd_committer freebsd_triage 2017-07-27 15:39:53 UTC
I was testing the same change last night and have just pushed it to the review.  It is a bit of a hack because I can't use OSVERSION until after Uses/compiler.mk has been sourced.

portmgr, can you retest?  Thanks
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2017-07-28 08:35:36 UTC
The last version builds fine on 10.3
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-07-28 21:21:29 UTC
A commit references this bug:

Author: jhb
Date: Fri Jul 28 21:20:49 UTC 2017
New revision: 446852
URL: https://svnweb.freebsd.org/changeset/ports/446852

Log:
  Upgrade to GDB 8.0.

  - Commit b5430a3ced fixes parsing of 32-bit MIPS process cores.
  - kgdb has been ported to 8.0 including renaming the new OSABI constant,
    using gdb_bfd_openr, new return type of ldirname, and solib_add
    changed.
  - GDB 8.0 requires C++11, however the port is marked as requiring C++14
    as a workaround for bugs in clang 10.3.
  - patch-armfbsd is updated for the new OSABI constant names (a.out was
    removed in 8.0) and new filename convention (arm-fbsd-*)
  - patch-gdb-amd64-bsd-nat.c (renamed from patch-gdbamd64-bsd-nat.c) is
    simplified to just store the r_flags value before collecting registers
    from the register cache rather than a full copy of the entire register
    set.
  - patch-gdb-corelow.c has been removed.  It isn't really correct and if
    arm cores still cause core dumps the error is in arm-fbsd-tdep.c.
  - patch-gdb-i386-fbsd-nat.c renamed to account for rename of patched
    file.
  - patch-gdb-x86bsd-nat.c has been removed.  The file was renamed, but the
    stock file also compiled fine for me on i386.

  PR:		221025 (exp-run for 10.3)
  Submitted by:	luca.pizzamiglio@gmail.com (original version)
  Reviewed by:	luca.pizzamiglio@gmail.com (maintainer)
  Approved by:	brooks
  Differential Revision:	https://reviews.freebsd.org/D11465

Changes:
  head/devel/gdb/Makefile
  head/devel/gdb/distinfo
  head/devel/gdb/files/commit-387360daf9
  head/devel/gdb/files/commit-b268007c68
  head/devel/gdb/files/commit-b5430a3ced
  head/devel/gdb/files/extrapatch-kgdb
  head/devel/gdb/files/kgdb/amd64fbsd-kern.c
  head/devel/gdb/files/kgdb/fbsd-kld.c
  head/devel/gdb/files/kgdb/fbsd-kthr.c
  head/devel/gdb/files/kgdb/fbsd-kvm.c
  head/devel/gdb/files/kgdb/i386fbsd-kern.c
  head/devel/gdb/files/kgdb/kgdb.h
  head/devel/gdb/files/kgdb/mipsfbsd-kern.c
  head/devel/gdb/files/kgdb/ppcfbsd-kern.c
  head/devel/gdb/files/kgdb/sparc64fbsd-kern.c
  head/devel/gdb/files/patch-armfbsd
  head/devel/gdb/files/patch-fixes
  head/devel/gdb/files/patch-gdb-amd64-bsd-nat.c
  head/devel/gdb/files/patch-gdb-amd64bsd-nat.c
  head/devel/gdb/files/patch-gdb-configure
  head/devel/gdb/files/patch-gdb-corelow.c
  head/devel/gdb/files/patch-gdb-fbsd-nat.c
  head/devel/gdb/files/patch-gdb-gnulib-import-stddef.in.h
  head/devel/gdb/files/patch-gdb-i386-fbsd-nat.c
  head/devel/gdb/files/patch-gdb-i386fbsd-nat.c
  head/devel/gdb/files/patch-gdb-x86bsd-nat.c