Bug 221229 - Mk/Uses/shebangfix.mk: Improve implementation
Summary: Mk/Uses/shebangfix.mk: Improve implementation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Felder
URL: https://reviews.freebsd.org/D11853
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-04 18:52 UTC by Mark Felder
Modified: 2017-08-08 01:12 UTC (History)
1 user (show)

See Also:
antoine: exp-run+

Attachments
shebang patch (415 bytes, patch)
2017-08-04 18:52 UTC, Mark Felder 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Felder freebsd_committer freebsd_triage 2017-08-04 18:52:38 UTC 
Created attachment 185028 [details]
shebang patch

More details in the review:

https://reviews.freebsd.org/D11853
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2017-08-07 14:27:11 UTC 
Exp-run looks fine.
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-08-08 01:11:23 UTC 
A commit references this bug:

Author: feld
Date: Tue Aug  8 01:10:57 UTC 2017
New revision: 447527
URL: https://svnweb.freebsd.org/changeset/ports/447527

Log:
  Mk/Uses/shebangfix.mk: Fix SHEBANG_FILES to use find(1)

  Ports like net/vmware-vsphere-cli use SHEBANG_FILES with globs like so:

  SHEBANG_FILES= bin/* ...

  As of FreeBSD 11.1-RELEASE sed has changed and errors if attempted on non-file
  objects. In the case of the cited port there are many other files in the
  bin/ directory which are symlinks for compatibility with old scripts.
  This causes the port patching to fail.

  PR:		221229
  Differential Revision:	https://reviews.freebsd.org/D11853

Changes:
  head/Mk/Uses/shebangfix.mk
Comment 3 Mark Felder freebsd_committer freebsd_triage 2017-08-08 01:12:00 UTC 
Thanks everyone!
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-08 01:12:25 UTC 
A commit references this bug:

Author: feld
Date: Tue Aug  8 01:11:42 UTC 2017
New revision: 447528
URL: https://svnweb.freebsd.org/changeset/ports/447528

Log:
  MFH: r447527

  Mk/Uses/shebangfix.mk: Fix SHEBANG_FILES to use find(1)

  Ports like net/vmware-vsphere-cli use SHEBANG_FILES with globs like so:

  SHEBANG_FILES= bin/* ...

  As of FreeBSD 11.1-RELEASE sed has changed and errors if attempted on non-file
  objects. In the case of the cited port there are many other files in the
  bin/ directory which are symlinks for compatibility with old scripts.
  This causes the port patching to fail.

  PR:		221229
  Differential Revision:	https://reviews.freebsd.org/D11853

  Approved by:	portmgr (with hat)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/Mk/Uses/shebangfix.mk