Bug 221370 - New port : sysutils/mkdesktop (the cool way to setup a FreeBSD desktop)
Summary: New port : sysutils/mkdesktop (the cool way to setup a FreeBSD desktop)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-09 15:43 UTC by bourne.identity@hotmail.com
Modified: 2018-05-17 15:48 UTC (History)
2 users (show)

See Also:


Attachments
Contains the shar for the new port mkdesktop (35.49 KB, text/plain)
2017-08-09 15:43 UTC, bourne.identity@hotmail.com
no flags Details
The original shar had a minor error; this attachment is the corrected shar (35.51 KB, text/plain)
2017-08-10 12:30 UTC, bourne.identity@hotmail.com
no flags Details
Improved the documentation in pkg-descr / --usage (35.70 KB, text/plain)
2017-08-11 13:23 UTC, bourne.identity@hotmail.com
no flags Details
New shar containing 3 improvments as suggested by actual usage (37.96 KB, text/plain)
2017-08-13 08:49 UTC, bourne.identity@hotmail.com
no flags Details
Contains tar that holds updated shar + portlint log + poudriere log (53.50 KB, application/x-tar)
2017-08-15 12:08 UTC, bourne.identity@hotmail.com
no flags Details
Contains the shar for the new port mkdesktop with a minor correction (38.43 KB, text/plain)
2017-08-15 14:59 UTC, bourne.identity@hotmail.com
no flags Details
Corrected shar with updated distinfo (38.43 KB, text/plain)
2017-08-15 15:30 UTC, bourne.identity@hotmail.com
no flags Details
Contains shar with help-file corrected for very long lines (38.56 KB, text/plain)
2017-08-15 17:15 UTC, bourne.identity@hotmail.com
no flags Details
Updated shar for the new port mkdesktop (38.47 KB, text/plain)
2017-08-16 12:14 UTC, bourne.identity@hotmail.com
no flags Details
shar with minor update to Makefile (38.48 KB, text/plain)
2017-08-16 14:40 UTC, bourne.identity@hotmail.com
no flags Details
shar updated with GitHub Makefile (2.39 KB, text/plain)
2017-08-17 06:59 UTC, bourne.identity@hotmail.com
no flags Details
mkdesktop script had 2 errors; now corrected (2.45 KB, text/plain)
2017-09-12 14:30 UTC, bourne.identity@hotmail.com
no flags Details
Output formatting improved to curb excess text per screen (2.34 KB, text/plain)
2017-09-18 01:42 UTC, bourne.identity@hotmail.com
no flags Details
Output formatting improved : inverse colours to underlined text (2.34 KB, text/plain)
2017-09-18 16:41 UTC, bourne.identity@hotmail.com
no flags Details
shar with minor update to mkdesktop script (2.45 KB, text/plain)
2017-10-16 12:20 UTC, bourne.identity@hotmail.com
no flags Details
Updated port files for new release of mkdesktop (2.33 KB, text/plain)
2018-05-17 15:48 UTC, bourne.identity@hotmail.com
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description bourne.identity@hotmail.com 2017-08-09 15:43:25 UTC
Created attachment 185207 [details]
Contains the shar for the new port mkdesktop

mkdesktop is a Bourne script that helps to standardize the process of FreeBSD desktop installation as much as possible per user, with plenty of flexibility as well as modularity. By default, you get 5 distinct stages for defining your    desktop environment. But you can always add/subtract/customize the stages as much as you wish. Once you start using mkdesktop, you will pretty soon love it.
Comment 1 bourne.identity@hotmail.com 2017-08-10 12:30:55 UTC
Created attachment 185232 [details]
The original shar had a minor error; this attachment is the corrected shar
Comment 2 bourne.identity@hotmail.com 2017-08-11 13:23:05 UTC
Created attachment 185289 [details]
Improved the documentation in pkg-descr / --usage

pkg-descr includes a line about the postprocessor. The script's --usage function uses a backslash to esacpe the $ of $EDITOR.
Comment 3 bourne.identity@hotmail.com 2017-08-13 08:49:40 UTC
Created attachment 185351 [details]
New shar containing 3 improvments as suggested by actual usage

Actual usage by an associate led to a few suggestions for improvement, which I entirely agreed with and have incorporated in the new shar being submitted :

1)  A preview is first shown of what the stages are going to install. If the preview seems right to the user, actual installation then commences

2) User gets a chance to optionally pass --yes to 'pkg install' at runtime so that the stages get installed non-interactively

3) An additional command-line switch has been thrown in to let the user disable post-processing.

Thanks
Manish Jain
Comment 4 bourne.identity@hotmail.com 2017-08-15 12:08:40 UTC
Created attachment 185443 [details]
Contains tar that holds updated shar + portlint log + poudriere log

Since I am a new port developer, I did not know how to write the Makefile correctly for portlint/poudriere. Have modified the Makefile so that portlint/poudriere run it clean. The tar contains the new shar, portlint log and poudriere log.
Comment 5 bourne.identity@hotmail.com 2017-08-15 14:59:46 UTC
Created attachment 185448 [details]
Contains the shar for the new port mkdesktop with a minor correction

I noticed a small type error in the diagnostics section. I have corrected that. I am now uploading just the shar, rather than tar containing shar + logs. If you want the portlint/poudriere logs, please message me and I shall upload them too.
Comment 6 bourne.identity@hotmail.com 2017-08-15 15:30:54 UTC
Created attachment 185449 [details]
Corrected shar with updated distinfo

The distinfo was unfortunately not updated in the previous upload. Am correcting that now.
Comment 7 bourne.identity@hotmail.com 2017-08-15 17:15:34 UTC
Created attachment 185453 [details]
Contains shar with help-file corrected for very long lines
Comment 8 Richard Gallamore freebsd_committer freebsd_triage 2017-08-16 04:02:54 UTC
This look cool. I'v learned some new things just reading the script. I have a couple things I want to suggest.

First, I create a repository and start some version control. I recommend using git. It is a bit complex and difficult to use at first, but it pays off. Create a github account and add it there. On the port, add USE_GITHUB= yes with the required variables, usually being GH_ACCOUNT, and sometimes GH_PROJECT. This will fix most of the problems I see right now.

${PREFIX}/share/${PORTNAME}, this is the same as ${DATADIR}

Overall I like what you are doing, thanks for your contributions I look forward to testing. =]
Comment 9 bourne.identity@hotmail.com 2017-08-16 12:14:00 UTC
Created attachment 185481 [details]
Updated shar for the new port mkdesktop

As suggested by Yuri Victorovich, have rectified Makefile :

<<
You need to align all values at the level of 2 tabs.
You need to make MASTER_SITES= DISTFILES= empty.

No need for NO_WRKSUBDIR=
>>
Comment 10 bourne.identity@hotmail.com 2017-08-16 14:40:51 UTC
Created attachment 185488 [details]
shar with minor update to Makefile

Makefile was referring to paths as files/ rather than ${FILESDIR}/
Comment 11 bourne.identity@hotmail.com 2017-08-17 06:59:08 UTC
Created attachment 185514 [details]
shar updated with GitHub Makefile

Now GH is being used, thanks to Richard and Yuri
Comment 12 bourne.identity@hotmail.com 2017-09-12 14:30:28 UTC
Created attachment 186298 [details]
mkdesktop script had 2 errors; now corrected

I came across 2 errors in mkdesktop in the post-processing for devfs.conf. I have corrected the script and made a couple of other improvements. The updated script has been uploaded to GH
Comment 13 bourne.identity@hotmail.com 2017-09-18 01:42:21 UTC
Created attachment 186495 [details]
Output formatting improved to curb excess text per screen

With a couple of bug fixes and improved output formatting, the port version is herewith being up from 1.0 to 1.1
Comment 14 bourne.identity@hotmail.com 2017-09-18 16:41:20 UTC
Created attachment 186514 [details]
Output formatting improved : inverse colours to underlined text

Stage names are now displayed underlined - visually better than the previous strategy of inverse colours
Comment 15 bourne.identity@hotmail.com 2017-10-16 12:20:50 UTC
Created attachment 187213 [details]
shar with minor update to mkdesktop script

Spotted a couple of typos in shell script's LINENO handling. Version being bumped up to 1.6
Comment 16 commit-hook freebsd_committer freebsd_triage 2017-10-25 03:02:52 UTC
A commit references this bug:

Author: ultima
Date: Wed Oct 25 03:01:57 UTC 2017
New revision: 452829
URL: https://svnweb.freebsd.org/changeset/ports/452829

Log:
  mkdesktop is a Bourne script that helps to standardize the process of FreeBSD
  desktop installation as much as possible per user, with plenty of flexibility as
  well as modularity. By default, you get 5 distinct stages for defining your
  desktop environment. But you can always add/subtract/customize the stages as
  much as you wish. Once you start using mkdesktop, you will pretty soon love it -
  particularly its post-processor which automatically kicks in once the stages
  have been processed - it sets up emulation layers and configuration of system
  files, if the user so desires.

  WWW: https://github.com/bourne-again/mkdesktop

  PR:		221370
  Submitted by:	born^@hotmail.com (maintainer)

Changes:
  head/sysutils/Makefile
  head/sysutils/mkdesktop/
  head/sysutils/mkdesktop/Makefile
  head/sysutils/mkdesktop/distinfo
  head/sysutils/mkdesktop/pkg-descr
Comment 17 Richard Gallamore freebsd_committer freebsd_triage 2017-10-25 03:06:18 UTC
Had to make a few changes but its done. I removed the LICENSE because there is nothing indicating that is the correct license in the source. Please add the license in the source and readd it in a future release.
Comment 18 bourne.identity@hotmail.com 2018-05-17 15:48:36 UTC
Created attachment 193486 [details]
Updated port files for new release of mkdesktop

Since kde4 package names have changed (kde-baseapps -> kde-baseapps-kde4), mkdesktop needed to be updated. The shar contains the port files (Makefile + distinfo + pkg-descr) for updated mkdesktop