Bug 222130 - textproc/freexl: update to 1.0.4
Summary: textproc/freexl: update to 1.0.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-07 21:25 UTC by Loïc Bartoletti
Modified: 2017-10-23 13:25 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+
madpilot: merge-quarterly+


Attachments
Freexl 1.0.4 (1.32 KB, patch)
2017-09-07 21:25 UTC, Loïc Bartoletti
no flags Details | Diff
VUXML freexl 1.0.3 (1.96 KB, patch)
2017-10-13 16:28 UTC, Loïc Bartoletti
lbartoletti: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2017-09-07 21:25:20 UTC
Created attachment 186152 [details]
Freexl 1.0.4

The Cisco Talos team reported two sensitive security issues
affecting FreeXL-1.0.3 and any previous version.

"A specially crafted XLS file can cause a memory corruption
resulting in remote code execution.  An attacker can send 
malicious XLS file to trigger this vulnerability."

Freexl-1.0.4 fixes both issues.

---
It's an easy patch.

I have fixed the MPL license.

Poudriere 10, 11 i386/amd64 OK
portlint OK
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2017-10-11 08:01:59 UTC
I'm testing the update, will not take long.

You mention security issues in your submission. Do you have a pointer to some advisory?

In fact you should also provide a diff to security/vuxml with the details of the vulnerabilities being addressed.

How to do this is described here:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/security-notify.html

It just requires you to fill a few fields in an xml file.

Can you submit such a diff in addition to the patch?

Thanks in advance.
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2017-10-13 16:28:59 UTC
Created attachment 187140 [details]
VUXML freexl 1.0.3
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-10-14 10:46:44 UTC
A commit references this bug:

Author: madpilot
Date: Sat Oct 14 10:46:25 UTC 2017
New revision: 452053
URL: https://svnweb.freebsd.org/changeset/ports/452053

Log:
  Document textproc/freexl security vulnerabilities.

  PR:		222130
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)

Changes:
  head/security/vuxml/vuln.xml
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-14 10:49:48 UTC
A commit references this bug:

Author: madpilot
Date: Sat Oct 14 10:49:28 UTC 2017
New revision: 452054
URL: https://svnweb.freebsd.org/changeset/ports/452054

Log:
  Update textproc/freexl to 1.0.4

  PR:		222130
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)
  MFH:		2017Q4
  Security:	555cd806-b031-11e7-a369-14dae9d59f67

Changes:
  head/textproc/freexl/Makefile
  head/textproc/freexl/distinfo
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2017-10-14 10:55:57 UTC
Committed, waiting for merge before closing.

I modified the vuxml entry slightly.

Looking at the source of the software it looks like the vulnerable code has always been present, so I made it mark all previous versions as vulnerable.

I also added URLS to the TALOS advisories, also because the CVE ones seem to having been allocated but still not filed out with actual data.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-10-23 13:24:03 UTC
A commit references this bug:

Author: madpilot
Date: Mon Oct 23 13:23:24 UTC 2017
New revision: 452709
URL: https://svnweb.freebsd.org/changeset/ports/452709

Log:
  MFH: r452054

  Update textproc/freexl to 1.0.4

  PR:		222130
  Submitted by:	lbartoletti@tuxfamily.org (maintainer)
  Security:	555cd806-b031-11e7-a369-14dae9d59f67

  Approved by:	ports-secteam (swills)

Changes:
_U  branches/2017Q4/
  branches/2017Q4/textproc/freexl/Makefile
  branches/2017Q4/textproc/freexl/distinfo
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2017-10-23 13:25:48 UTC
Merged to quarterly. Thanks!