Bug 222135 - mail/qpopper: Add license, switch to options helpers
Summary: mail/qpopper: Add license, switch to options helpers
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-08 06:19 UTC by takefu
Modified: 2018-12-25 07:17 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback+

Attachments
qpopper-4.1.0_6.patch (20.96 KB, patch)
2017-09-08 06:19 UTC, takefu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2017-09-08 06:19:36 UTC 
Created attachment 186163 [details]
qpopper-4.1.0_6.patch

Change MASTER_SITES
Add LICENSE
Delete unnecessary variables
OPTIONS optimization
portlint(1) Compliant
Comment 1 bc979 2017-09-09 05:12:09 UTC 
I am currently in the direct path of Irma and will probably not have power for a few weeks.  In addition, I no longer use qpopper.  However, The only potential issue I see with this patch is the re-introduction of APOP.  In the past APOP caused numerous issues for users and was removed from the default configuration.  I don't know how may are still using qpopper and if they are using APOP.

-- Doug bc979@lafn.org
Comment 2 takefu 2017-09-11 00:31:49 UTC 
Would you like to remove the APOP function from the option?(In reply to bc979 from comment #1)

Would you like to remove the APOP function from the option?
Comment 3 bc979 2017-09-11 01:16:43 UTC 
It doesn't matter to me.  I brought that up because of the previous discussions a few years ago.  I am good with it either way.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2018-08-13 12:39:20 UTC 
(In reply to takefu from comment #0)
The patch doesn't apply anymore and needs a rebase.

Since you have to update the patch anyway, could you please group all option
descriptions into one block before the options helpers (see [1])?

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html

(In reply to bc979 from comment #1)
> In addition, I no longer use qpopper.

Should we reset MAINTAINER as well then?
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-25 07:16:22 UTC 
A commit references this bug:

Author: tobik
Date: Tue Dec 25 07:16:02 UTC 2018
New revision: 488295
URL: https://svnweb.freebsd.org/changeset/ports/488295

Log:
  mail/qpopper: Reset maintainer

  The maintainer no longer uses qpopper.

  PR:		222135

Changes:
  head/mail/qpopper/Makefile
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-12-25 07:17:48 UTC 
Closing as patch wasn't rebased and no additional feedback was given
for > 4 months.