Bug 222224 - www/node4: fails to build with ICU 59.1 (5 ports skipped)
Summary: www/node4: fails to build with ICU 59.1 (5 ports skipped)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL: https://ssl.icu-project.org/trac/chan...
Keywords: needs-patch
Depends on:
Blocks: 218788
  Show dependency tree / graph
 
Reported: 2017-09-11 12:47 UTC by Jan Beich
Modified: 2017-09-15 06:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (bhughes)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-09-11 12:47:48 UTC 
../deps/v8/src/runtime/runtime-i18n.cc:587:3: error: no member named 'Normalizer' in namespace 'icu'; did you mean 'UNormalizer2'?
  icu::Normalizer::normalize(u_value, normalizationForms[form_id], 0, result,
  ^~~~~~~~~~~~~~~
  UNormalizer2
/usr/local/include/unicode/unorm2.h:119:29: note: 'UNormalizer2' declared here
typedef struct UNormalizer2 UNormalizer2;  /**< C typedef for struct UNormalizer2. @stable ICU 4.4 */
                            ^
../deps/v8/src/runtime/runtime-i18n.cc:587:8: error: incomplete type 'UNormalizer2' named in nested name specifier
  icu::Normalizer::normalize(u_value, normalizationForms[form_id], 0, result,
  ~~~~~^~~~~~~~~~~~
/usr/local/include/unicode/unorm2.h:118:8: note: forward declaration of 'UNormalizer2'
struct UNormalizer2;
       ^

http://package23.nyi.freebsd.org/data/103i386-default-PR218788/2017-05-17_09h18m57s/logs/errors/node4-4.8.3.log
Comment 1 Bradley T. Hughes freebsd_committer freebsd_triage 2017-09-14 12:41:29 UTC 
Since this is a failure in V8, I am wondering if I should drop the devel/icu dependency from www/node4 and instead use the bundled icu-small. Not the ideal though, I must admit.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-09-14 18:08:40 UTC 
How old is bundled ICU? Is it affected by CVE-2017-786{7,8} or older vulnerabilites?
Comment 3 Jan Beich freebsd_committer freebsd_triage 2017-09-14 18:27:37 UTC 
Doh, comment 0 is due to a missing header.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-09-14 18:45:36 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Sep 14 18:45:06 UTC 2017
New revision: 449849
URL: https://svnweb.freebsd.org/changeset/ports/449849

Log:
  www/node4: unbreak with ICU >= 59

  ../deps/v8/src/runtime/runtime-i18n.cc:587:3: error: no member named 'Normalizer' in namespace 'icu'; did you mean 'UNormalizer2'?
    icu::Normalizer::normalize(u_value, normalizationForms[form_id], 0, result,
    ^~~~~~~~~~~~~~~
    UNormalizer2
  /usr/local/include/unicode/unorm2.h:119:29: note: 'UNormalizer2' declared here
  typedef struct UNormalizer2 UNormalizer2;  /**< C typedef for struct UNormalizer2. @stable ICU 4.4 */
                              ^
  ../deps/v8/src/runtime/runtime-i18n.cc:587:8: error: incomplete type 'UNormalizer2' named in nested name specifier
    icu::Normalizer::normalize(u_value, normalizationForms[form_id], 0, result,
    ~~~~~^~~~~~~~~~~~
  /usr/local/include/unicode/unorm2.h:118:8: note: forward declaration of 'UNormalizer2'
  struct UNormalizer2;
         ^

  PR:		222224

Changes:
  head/www/node4/files/
  head/www/node4/files/patch-deps_v8_src_runtime_runtime-i18n.cc
Comment 5 Bradley T. Hughes freebsd_committer freebsd_triage 2017-09-15 06:42:26 UTC 
Just a one line change, that's great :D