Bug 222287 - security/fwknop: Fix Makefile
Summary: security/fwknop: Fix Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-13 14:02 UTC by Jens Grassel
Modified: 2017-09-15 20:52 UTC (History)
2 users (show)

See Also:
sean.greven: maintainer-feedback+

Attachments
Patchfile (484 bytes, patch)
2017-09-13 14:02 UTC, Jens Grassel 		no flags Details | Diff
Update to fwknop updating to latest version, Also including Patch from Jens (1.43 KB, patch)
2017-09-14 13:42 UTC, sean.greven 		sean.greven: maintainer-approval+
Details | Diff
Updated Patchfile (1.62 KB, patch)
2017-09-15 20:29 UTC, sean.greven 		sean.greven: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Grassel 2017-09-13 14:02:30 UTC 
Created attachment 186330 [details]
Patchfile

Hi,

fwknop actually needs wget at build and runtime therefore I've attached a patch to include the appropriate build and run dependency settings in the Makefile.

Regards,

Jens
Comment 1 sean.greven 2017-09-14 13:37:27 UTC 
Comment on attachment 186330 [details]
Patchfile

Thanks for that Jens, I have verified the requirement, thanks for the patch.  I declined the approval, because I actually just rolled the change into the 2.6.9 patch which I am submitting now.

Regards Sean
Comment 2 sean.greven 2017-09-14 13:42:46 UTC 
Created attachment 186379 [details]
Update to fwknop updating to latest version, Also including Patch from Jens

Update to fwknop updating to latest version

Includes Patch from Jens to include wget dependency
Comment 3 Jens Grassel 2017-09-15 07:21:44 UTC 
Cool, thanks. =)
Comment 4 Steve Wills freebsd_committer freebsd_triage 2017-09-15 18:18:22 UTC 
Attachment 186379 [details] applies cleanly for me.
Comment 5 Steve Wills freebsd_committer freebsd_triage 2017-09-15 18:20:45 UTC 
Found a few slight issues when build testing this tho:

====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/fwknop is linked to /usr/local/lib/libassuan.so.0 from security/libassuan but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libassuan.so:security/libassuan
Error: /usr/local/bin/fwknop is linked to /usr/local/lib/libgpg-error.so.0 from security/libgpg-error but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libgpg-error.so:security/libgpg-error
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: info/dir
Error: Missing: info/libfko.info
===> Error: Plist issues found.
Comment 6 sean.greven 2017-09-15 20:27:45 UTC 
(In reply to Steve Wills from comment #5)
Thank you for that Steve

I have uploaded a modified patch fixing the warnings and the plist file
Comment 7 sean.greven 2017-09-15 20:29:36 UTC 
Created attachment 186422 [details]
Updated Patchfile

Update to fwknop updating to latest version, Also including Patch from Jens.
latest patch updates the Makefile and the plist file to include some missed dependencies.
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-09-15 20:50:49 UTC 
A commit references this bug:

Author: swills
Date: Fri Sep 15 20:49:54 UTC 2017
New revision: 449936
URL: https://svnweb.freebsd.org/changeset/ports/449936

Log:
  security/fwknop: update to 2.6.9

  Update to 2.6.9 [0]
  While here, add missing deps [1]

  PR:		222287
  Submitted by:	sean.greven@gmail.com (maintainer) [0][1]
  Reported by:	Jens Grassel <jan0sch@mykolab.com> [1]

Changes:
  head/security/fwknop/Makefile
  head/security/fwknop/distinfo
  head/security/fwknop/pkg-plist
Comment 9 Steve Wills freebsd_committer freebsd_triage 2017-09-15 20:52:46 UTC 
Committed, thanks!