Bug 222382 - security/fwknop: Compiler error with 2.6.9
Summary: security/fwknop: Compiler error with 2.6.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-17 06:18 UTC by Jens Grassel
Modified: 2017-10-05 19:28 UTC (History)
2 users (show)

See Also:
sean.greven: maintainer-feedback+


Attachments
Package Versions - Clean Install on 11.1 RELEASE (4.88 KB, text/plain)
2017-09-17 11:07 UTC, sean.greven
no flags Details
Package Versions - Compiler Error - Custom 11.1 RELEASE (123.35 KB, text/plain)
2017-09-18 09:39 UTC, Jens Grassel
no flags Details
Update the port Makefile to reflect the CONFLICT with previous fwknop version (546 bytes, patch)
2017-09-28 08:43 UTC, sean.greven
sean.greven: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Grassel 2017-09-17 06:18:27 UTC
Hi,

compiling the latest 2.6.9 gives the following error (I tried on 2 machines, both 11.1-RELEASE-p1):

    fwknop-2.6.9 configuration.
    ==========================================================
        Client build:               yes
        Server build:               yes
        GPG encryption support:     yes
                  Gpgme engine:     /usr/local/bin/gpg

        Installation prefix:        /usr/local

    Server support:
        firewall type:              pf
        firewall program path:      /sbin/pfctl

===>  Building for fwknop-2.6.9_1
--- all ---
/usr/bin/make  all-recursive
--- all-recursive ---
Making all in common
--- strlcpy.o ---
--- strlcat.o ---
--- fko_util.o ---
--- strlcpy.o ---
depbase=`echo strlcpy.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H -I. -I..  -I/usr/local/include -I ../common -I ../lib  -I/usr/local/include -I/usr/local/include/gpgme  -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT strlcpy.o -MD -MP -MF $depbase.Tpo -c -o strlcpy.o strlcpy.c && mv -f $depbase.Tpo $depbase.Po
--- strlcat.o ---
depbase=`echo strlcat.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H -I. -I..  -I/usr/local/include -I ../common -I ../lib  -I/usr/local/include -I/usr/local/include/gpgme  -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT strlcat.o -MD -MP -MF $depbase.Tpo -c -o strlcat.o strlcat.c && mv -f $depbase.Tpo $depbase.Po
--- fko_util.o ---
depbase=`echo fko_util.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc -DHAVE_CONFIG_H -I. -I..  -I/usr/local/include -I ../common -I ../lib  -I/usr/local/include -I/usr/local/include/gpgme  -O2 -pipe  -fstack-protector -fno-strict-aliasing -Wall -Wformat -Wformat-security -fstack-protector-all -fstack-protector -fPIE -fPIC -D_FORTIFY_SOURCE=2 -MT fko_util.o -MD -MP -MF $depbase.Tpo -c -o fko_util.o fko_util.c && mv -f $depbase.Tpo $depbase.Po
fko_util.c:256:16: error: use of undeclared identifier 'FKO_DIGEST_SHA3_256'; did you mean 'FKO_DIGEST_SHA256'?
        return(FKO_DIGEST_SHA3_256);
               ^~~~~~~~~~~~~~~~~~~
               FKO_DIGEST_SHA256
/usr/local/include/fko.h:78:5: note: 'FKO_DIGEST_SHA256' declared here
    FKO_DIGEST_SHA256,
    ^
fko_util.c:258:16: error: use of undeclared identifier 'FKO_DIGEST_SHA3_512'; did you mean 'FKO_DIGEST_SHA512'?
        return(FKO_DIGEST_SHA3_512);
               ^~~~~~~~~~~~~~~~~~~
               FKO_DIGEST_SHA512
/usr/local/include/fko.h:80:5: note: 'FKO_DIGEST_SHA512' declared here
    FKO_DIGEST_SHA512,
    ^
fko_util.c:299:14: error: use of undeclared identifier 'FKO_DIGEST_SHA3_256'; did you mean 'FKO_DIGEST_SHA256'?
        case FKO_DIGEST_SHA3_256:
             ^~~~~~~~~~~~~~~~~~~
             FKO_DIGEST_SHA256
/usr/local/include/fko.h:78:5: note: 'FKO_DIGEST_SHA256' declared here
    FKO_DIGEST_SHA256,
    ^
fko_util.c:302:14: error: use of undeclared identifier 'FKO_DIGEST_SHA3_512'; did you mean 'FKO_DIGEST_SHA512'?
        case FKO_DIGEST_SHA3_512:
             ^~~~~~~~~~~~~~~~~~~
             FKO_DIGEST_SHA512
/usr/local/include/fko.h:80:5: note: 'FKO_DIGEST_SHA512' declared here
    FKO_DIGEST_SHA512,
    ^
fko_util.c:299:14: error: duplicate case value 'FKO_DIGEST_SHA256'
        case FKO_DIGEST_SHA3_256:
             ^
fko_util.c:290:14: note: previous case defined here
        case FKO_DIGEST_SHA256:
             ^
fko_util.c:302:14: error: duplicate case value 'FKO_DIGEST_SHA512'
        case FKO_DIGEST_SHA3_512:
             ^
fko_util.c:296:14: note: previous case defined here
        case FKO_DIGEST_SHA512:
             ^
fko_util.c:328:16: error: use of undeclared identifier 'FKO_HMAC_SHA3_256'; did you mean 'FKO_HMAC_SHA256'?
        return(FKO_HMAC_SHA3_256);
               ^~~~~~~~~~~~~~~~~
               FKO_HMAC_SHA256
/usr/local/include/fko.h:91:5: note: 'FKO_HMAC_SHA256' declared here
    FKO_HMAC_SHA256,
    ^
fko_util.c:330:16: error: use of undeclared identifier 'FKO_HMAC_SHA3_512'; did you mean 'FKO_HMAC_SHA512'?
        return(FKO_HMAC_SHA3_512);
               ^~~~~~~~~~~~~~~~~
               FKO_HMAC_SHA512
/usr/local/include/fko.h:93:5: note: 'FKO_HMAC_SHA512' declared here
    FKO_HMAC_SHA512,
    ^
fko_util.c:409:14: error: use of undeclared identifier 'FKO_HMAC_SHA3_256'; did you mean 'FKO_HMAC_SHA256'?
        case FKO_HMAC_SHA3_256:
             ^~~~~~~~~~~~~~~~~
             FKO_HMAC_SHA256
/usr/local/include/fko.h:91:5: note: 'FKO_HMAC_SHA256' declared here
    FKO_HMAC_SHA256,
    ^
fko_util.c:412:14: error: use of undeclared identifier 'FKO_HMAC_SHA3_512'; did you mean 'FKO_HMAC_SHA512'?
        case FKO_HMAC_SHA3_512:
             ^~~~~~~~~~~~~~~~~
             FKO_HMAC_SHA512
/usr/local/include/fko.h:93:5: note: 'FKO_HMAC_SHA512' declared here
    FKO_HMAC_SHA512,
    ^
fko_util.c:409:14: error: duplicate case value 'FKO_HMAC_SHA256'
        case FKO_HMAC_SHA3_256:
             ^
fko_util.c:400:14: note: previous case defined here
        case FKO_HMAC_SHA256:
             ^
fko_util.c:412:14: error: duplicate case value 'FKO_HMAC_SHA512'
        case FKO_HMAC_SHA3_512:
             ^
fko_util.c:406:14: note: previous case defined here
        case FKO_HMAC_SHA512:
             ^
12 errors generated.
*** [fko_util.o] Error code 1

make[4]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9/common
1 error

make[4]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9/common
*** [all-recursive] Error code 1

make[3]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9
1 error

make[3]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9
*** [all] Error code 2

make[2]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9
1 error

make[2]: stopped in /usr/ports/security/fwknop/work/fwknop-2.6.9
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/security/fwknop
*** Error code 1

Stop.
make: stopped in /usr/ports/security/fwknop

Configuration as follows:

===> The following configuration options are available for fwknop-2.6.9_1:
     GPGME=on: Build support for gpgme
====> Firewall Backend: you have to select exactly one of them
     IPFW=off: Use the IPFW firewall
     PF=on: Use the PF firewall.
===> Use 'make config' to modify these settings

If GPGME is disabled the port builds fine.

Regards,

Jens
Comment 1 sean.greven 2017-09-17 11:07:09 UTC
Created attachment 186454 [details]
Package Versions - Clean Install on 11.1 RELEASE

Clean install on 11.1 - Package versions for comparison
Comment 2 sean.greven 2017-09-17 11:11:35 UTC
Hi Jens


I checked the install on a clean install of 11.1.  It compiles cleanly, I suspect some installed port/package version clash is the reason for this.

I would recommend a portmaster -a

However in the mean time, I have added an attachment with the Package Versions installed on a clean install of 11.1.  Perhaps you can just compare against the versions you have installed.  Lets inspect the differences.


Regards Sean
Comment 3 Jens Grassel 2017-09-18 09:39:34 UTC
Created attachment 186505 [details]
Package Versions - Compiler Error - Custom 11.1 RELEASE

I just checked on my workstation which doesn't compile it either. So I've attached to pkg list of it.
Comment 4 sean.greven 2017-09-19 16:33:01 UTC
Hi Jens

I have checked the versions, and outside of fwknop, all the library versions are the same.  I suspect it has something to do with the fko library that is installed with the previous version of fwknop.

I am trying to replicate the exact conditions, but am so far unable.  I will continue trying tho.  Is is possible possibly to try uninstalling fwknop (the old version) and they trying to install the new one ?

Regards Sean
Comment 5 Jens Grassel 2017-09-19 16:52:07 UTC
Hi Sean,

removing the old fwknop package before building the new one indeed solves the problem. Maybe an entry in /usr/ports/UPDATING should be made regarding this.

Thanks,

Jens
Comment 6 sean.greven 2017-09-28 08:43:50 UTC
Created attachment 186777 [details]
Update the port Makefile to reflect the CONFLICT with previous fwknop version

I Updated the port Makefile to reflect the BUILD_CONFLICT with previous fwknop version.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-10-05 19:28:33 UTC
A commit references this bug:

Author: cs
Date: Thu Oct  5 19:27:45 UTC 2017
New revision: 451339
URL: https://svnweb.freebsd.org/changeset/ports/451339

Log:
  Resolve conflict

  PR:		222382
  Submitted by:	Jens Grassel <jan0sch@mykolab.com>
  Approved by:	maintainer

Changes:
  head/security/fwknop/Makefile