Bug 222517 - graphics/pngcrush: Update to 1.8.13
Summary: graphics/pngcrush: Update to 1.8.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-09-22 19:26 UTC by lightside
Modified: 2017-09-29 20:14 UTC (History)
1 user (show)

See Also:
vsasjason: maintainer-feedback+

Attachments
Proposed patch (since 425824 revision) (2.69 KB, patch)
2017-09-22 19:26 UTC, lightside 		no flags Details | Diff
Proposed patch (since 425824 revision) (2.69 KB, patch)
2017-09-22 19:46 UTC, lightside 		vsasjason: maintainer-approval+
Details | Diff
poudriere testport log on releng/11.1 (12.71 KB, text/plain)
2017-09-24 12:36 UTC, Anton Saietskii 		no flags Details
Proposed patch (since 425824 revision, with license definition) (2.85 KB, patch)
2017-09-24 16:07 UTC, lightside 		vsasjason: maintainer-approval-
Details | Diff
Proposed patch (since 425824 revision) (2.84 KB, patch)
2017-09-24 17:19 UTC, lightside 		vsasjason: maintainer-approval+
Details | Diff
poudriere testport log on releng/11.1 (after adding LICENSE) (12.48 KB, text/plain)
2017-09-24 17:25 UTC, Anton Saietskii 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2017-09-22 19:26:48 UTC 
Created attachment 186618 [details]
Proposed patch (since 425824 revision)

Patch to update graphics/pngcrush port from 1.8.7 to 1.8.13 version.

Look following link for changes:
https://sourceforge.net/projects/pmt/files/pngcrush/1.8.13/ChangeLog.html/download

- Return MASTER_SITES from ports r410992
- Remove unused PNGCRUSH_COUNT_COLORS define from CFLAGS (since 1.7.48 version)
- Replace CFLAGS and LDFLAGS with USES+=localbase:ldflags
- Replace files/patch-Makefile with CPPFLAGS value in MAKE_ARGS and sed patch for LIBS variable

The build was tested on FreeBSD 10.3 amd64.
Comment 1 lightside 2017-09-22 19:46:50 UTC 
Created attachment 186619 [details]
Proposed patch (since 425824 revision)

Clarified sed patch, just in case.
Comment 2 Anton Saietskii 2017-09-24 12:36:28 UTC 
Created attachment 186659 [details]
poudriere testport log on releng/11.1
Comment 3 Anton Saietskii 2017-09-24 12:38:30 UTC 
Comment on attachment 186619 [details]
Proposed patch (since 425824 revision)

Looks ok for me. Note there is a warning about LICENSE - I plan to fix this later because I have not enough time currently.
Comment 4 lightside 2017-09-24 16:07:13 UTC 
Created attachment 186667 [details]
Proposed patch (since 425824 revision, with license definition)

(In reply to from comment #3)
> Looks ok for me.
Thanks for review.

(In reply to from comment #3)
> Note there is a warning about LICENSE
Yes, I saw following warning from portlint output:
WARN: Makefile: Consider defining LICENSE.

Looks like, the pngcrush has a custom license. According to https://pmt.sourceforge.io/pngcrush/
-8<--
Pngcrush is open source and may be used, modified, and redistributed by anyone without paying a fee. The license, embedded in the file pngcrush.c, is equivalent but not identical to the libpng license found in the libpng file png.h.
-->8-

I attached new proposed patch with possible license definition. Please review it.
I can remove/obsolete attachment #186619 [details] in case of possible approval of new patch. Suggestions are welcome.
Comment 5 Anton Saietskii 2017-09-24 17:05:39 UTC 
Comment on attachment 186667 [details]
Proposed patch (since 425824 revision, with license definition)

// It's better to reset maintainer-feedback to '?' to block possible commit.

According to LICENSE file, pngcrush should be redistributed free in any form:
> Permission is hereby irrevocably granted to everyone to use, copy, modify, and distribute this source code, or portions hereof, or executable programs compiled from it, for any purpose, ***without payment of any fee***, subject to the following restrictions:
So I think that LICENSE_PERMS should be changed to "dist-mirror pkg-mirror auto-accept"
Comment 6 lightside 2017-09-24 17:19:28 UTC 
Created attachment 186670 [details]
Proposed patch (since 425824 revision)

(In reply to comment #5)
> So I think that LICENSE_PERMS should be changed to
> "dist-mirror pkg-mirror auto-accept"
Ok, done.
Comment 7 Anton Saietskii 2017-09-24 17:25:54 UTC 
Created attachment 186672 [details]
poudriere testport log on releng/11.1 (after adding LICENSE)
Comment 8 Anton Saietskii 2017-09-24 17:27:43 UTC 
Comment on attachment 186670 [details]
Proposed patch (since 425824 revision)

Now it's fully ready to commit. Thanks for your work & port updating help!
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-09-29 19:46:28 UTC 
A commit references this bug:

Author: swills
Date: Fri Sep 29 19:45:27 UTC 2017
New revision: 450933
URL: https://svnweb.freebsd.org/changeset/ports/450933

Log:
  graphics/pngcrush: Update to 1.8.13

  PR:		222517
  Submitted by:	lightside <lightside@gmx.com>
  Approved by:	Anton Sayetsky <vsasjason@gmail.com> (maintainer)

Changes:
  head/graphics/pngcrush/Makefile
  head/graphics/pngcrush/distinfo
  head/graphics/pngcrush/files/
Comment 10 Steve Wills freebsd_committer freebsd_triage 2017-09-29 20:14:10 UTC 
Committed, thanks!