Bug 222525 - www/py-aiohttp: update to upstream 2.3.6
Summary: www/py-aiohttp: update to upstream 2.3.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Olivier Cochard
URL:
Keywords:
Depends on: 222524 222978
Blocks:
  Show dependency tree / graph
 
Reported: 2017-09-23 08:46 UTC by Philip Paeps
Modified: 2017-12-19 06:33 UTC (History)
1 user (show)

See Also:

Attachments
update www/py-aiohttp to upstream 2.2.5 (942 bytes, text/plain)
2017-09-23 08:46 UTC, Philip Paeps 		no flags Details
update www/py-aiohttp to upstream 2.3.1 (1.25 KB, patch)
2017-10-20 18:28 UTC, Philip Paeps 		no flags Details | Diff
patch for updating it to 2.3.6 (892 bytes, patch)
2017-12-06 08:20 UTC, Olivier Cochard 		no flags Details | Diff
fixed patch for updating it to 2.3.6 (1.30 KB, patch)
2017-12-06 10:03 UTC, Olivier Cochard 		koobs: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Paeps freebsd_committer freebsd_triage 2017-09-23 08:46:34 UTC 
Created attachment 186628 [details]
update www/py-aiohttp to upstream 2.2.5

This patch updates www/py-aiohttp to upstream version 2.2.5.  Note that this version requires www/py-yarl to be updated to 0.12.0 or later.  See bug #222524 I submitted earlier.
Comment 1 Philip Paeps freebsd_committer freebsd_triage 2017-10-20 18:28:31 UTC 
Created attachment 187331 [details]
update www/py-aiohttp to upstream 2.3.1
Comment 2 Olivier Cochard freebsd_committer freebsd_triage 2017-12-06 08:20:34 UTC 
Created attachment 188576 [details]
patch for updating it to 2.3.6
Comment 3 Olivier Cochard freebsd_committer freebsd_triage 2017-12-06 08:42:51 UTC 
Oops: I've just read the diff review and found it's a little more complex port to upgrade this port. How can I remove my patch and the "obsolete" concept it brings ?
By the way I've got still the same 5 failed tests using latest multidict 3.3.2.
Comment 4 Philip Paeps freebsd_committer freebsd_triage 2017-12-06 09:19:39 UTC 
I think if you add the `TEST_DEPENDS` on py-pytest-mock like I did, your upgrade probably looks good.  I'm also not sure why the tests fail.  I filed a bug upstream about it, but it seems they can't reproduce it.
Comment 5 Olivier Cochard freebsd_committer freebsd_triage 2017-12-06 10:03:02 UTC 
Created attachment 188580 [details]
fixed patch for updating it to 2.3.6

Here is my updated patch with philip's patch merged.
Comment 6 Olivier Cochard freebsd_committer freebsd_triage 2017-12-13 14:31:05 UTC 
I've got a port to submit that need a minimum version 2.2 of py-aiohttp.
Then can this port be upgraded ?
Thanks
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2017-12-15 07:27:44 UTC 
Comment on attachment 188580 [details]
fixed patch for updating it to 2.3.6

Obsolete patch, review (accepted)  supersedes it
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2017-12-15 07:28:49 UTC 
Comment on attachment 188580 [details]
fixed patch for updating it to 2.3.6

Unobsolete, patch contains update to 2.3.6, differential only updates to 2.3.1
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2017-12-15 07:30:38 UTC 
attachment 188580 [details] is:

Approved by: koobs (maintainer)
Comment 10 commit-hook freebsd_committer freebsd_triage 2017-12-19 06:32:51 UTC 
A commit references this bug:

Author: olivier
Date: Tue Dec 19 06:31:53 UTC 2017
New revision: 456710
URL: https://svnweb.freebsd.org/changeset/ports/456710

Log:
  Update to 2.3.6

  PR:		222525
  Submitted by:	philip
  Approved by:	koobs (maintainer)

Changes:
  head/www/py-aiohttp/Makefile
  head/www/py-aiohttp/distinfo
Comment 11 Olivier Cochard freebsd_committer freebsd_triage 2017-12-19 06:33:40 UTC 
Committed: Thanks!