Bug 222608 - sysutils/py-google-compute-engine: update to 2.6.1
Summary: sysutils/py-google-compute-engine: update to 2.6.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Richard Gallamore
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-09-25 21:56 UTC by Helen Koike
Modified: 2018-03-27 17:56 UTC (History)
2 users (show)

See Also:


Attachments
Patch to update py-google-compute-engine to version 2.6.1 (20.13 KB, patch)
2017-09-25 21:56 UTC, Helen Koike
helen.koike: maintainer-approval+
Details | Diff
Poudriere build logs of google-compute-engine package 2.6.1 (100.00 KB, application/gzip)
2017-09-25 21:58 UTC, Helen Koike
no flags Details
Patch to update py-google-compute-engine to version 2.6.1 (20.13 KB, patch)
2017-11-22 19:41 UTC, Helen Koike
no flags Details | Diff
Patch to update py-google-compute-engine to version 2.6.1 generated using diff -u -r -N olddir newdir (24.04 KB, patch)
2017-11-22 19:51 UTC, Helen Koike
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Koike 2017-09-25 21:56:32 UTC
Created attachment 186722 [details]
Patch to update py-google-compute-engine to version 2.6.1

Please see attached patch which updates sysutils/py-google-compute-engine to version 2.6.1
Comment 1 Helen Koike 2017-09-25 21:58:12 UTC
Created attachment 186723 [details]
Poudriere build logs of google-compute-engine package 2.6.1
Comment 2 Tilman Keskinoz freebsd_committer freebsd_triage 2017-11-21 13:26:09 UTC
something is wrong with the patch, you are trying to patch /dev/null

Can you investigate?
Comment 3 Helen Koike 2017-11-22 19:41:30 UTC
Created attachment 188198 [details]
Patch to update py-google-compute-engine to version 2.6.1

(In reply to Tilman Keskinoz from comment #2)

This is how the diff unified format indicates a file was created or deleted, it compares against /dev/null
I was trying to diff against the svn tree but the patch doesn't inform when a file is created or deleted, and the FreeBsd "How to Contribute" page mention to use diff in unified format for patches.

Let me know if you prefer another format for the patch.

I am reattaching the patch rebased with the FreeBSD ports tree.
Comment 4 Helen Koike 2017-11-22 19:51:21 UTC
Created attachment 188199 [details]
Patch to update py-google-compute-engine to version 2.6.1 generated using diff -u -r -N olddir newdir

I am attaching the same patch generated by `diff -u -r -N olddir newdir`
Let me know if it is ok now.
I was using

    git difftool -y --extcmd="diff -u" origin/master > /tmp/freebsd-google-cloud-engine-2-6-1.patch

to force my git mirror use the unified format and it compares the new files with /dev/null (because there is no old file to compare with)

Please let me know if it is ok now.

Thanks
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-28 20:25:03 UTC
A commit references this bug:

Author: ultima
Date: Tue Nov 28 20:24:52 UTC 2017
New revision: 455073
URL: https://svnweb.freebsd.org/changeset/ports/455073

Log:
  * Updated to 2.6.1
  * Removed obsolete patch files

  PR:		222608
  Submitted by:	Helen Koike (maintainer)

Changes:
  head/sysutils/py-google-compute-engine/Makefile
  head/sysutils/py-google-compute-engine/distinfo
  head/sysutils/py-google-compute-engine/files/instance_configs.cfg.distro.sample
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_accounts_accounts__daemon.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_accounts_accounts__utils.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_boto_boto__config.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_boto_compute__auth.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_clock__skew_clock__skew__daemon.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_config__manager.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_instance__setup_instance__config.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_instance__setup_instance__setup.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_ip__forwarding_ip__forwarding__daemon.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_ip__forwarding_ip__forwarding__utils.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_metadata__scripts_script__executor.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_network__setup_network__setup.py
  head/sysutils/py-google-compute-engine/files/patch-google__compute__engine_network__utils.py
  head/sysutils/py-google-compute-engine/files/patch-setup.py
  head/sysutils/py-google-compute-engine/pkg-plist
Comment 6 Richard Gallamore freebsd_committer freebsd_triage 2017-11-28 20:25:32 UTC
Committed, thanks!