Bug 222651 - databases/soci: Compilation failed unexpectedly.
Summary: databases/soci: Compilation failed unexpectedly.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL: https://reviews.freebsd.org/D13769
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-27 19:25 UTC by Neel Chauhan
Modified: 2018-01-05 11:08 UTC (History)
1 user (show)

See Also:
jlaffaye: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2017-09-27 19:25:00 UTC 
When I compile databases/soci: I get this error:

[55/207] /usr/bin/c++  -DHAVE_BOOST=1 -DHAVE_BOOST_DATE_TIME=1 -DHAVE_MYSQL=1 -DSOCI_ABI_VERSION=\"3.2\" -I/usr/local/include/mysql -Icore -O2 -pipe -fstack-protector -fno-strict-aliasing -pedantic -ansi -Wall -Wpointer-arith -Wcast-align -Wcast-qual -Wfloat-equal -Wredundant-decls -Wno-long-long -O2 -pipe -fstack-protector -fno-strict-aliasing -MD -MT backends/mysql/CMakeFiles/soci_mysql_static.dir/standard-use-type.cpp.o -MF backends/mysql/CMakeFiles/soci_mysql_static.dir/standard-use-type.cpp.o.d -o backends/mysql/CMakeFiles/soci_mysql_static.dir/standard-use-type.cpp.o -c backends/mysql/standard-use-type.cpp
[56/207] /usr/bin/c++  -DSOCI_ABI_VERSION=\"3.2\" -DSOCI_LIB_PREFIX=\"libsoci_\" -DSOCI_LIB_SUFFIX=\".so\" -Dsoci_core_EXPORTS -Icore -O2 -pipe -fstack-protector -fno-strict-aliasing -pedantic -ansi -Wall -Wpointer-arith -Wcast-align -Wcast-qual -Wfloat-equal -Wredundant-decls -Wno-long-long -O2 -pipe -fstack-protector -fno-strict-aliasing -fPIC -MD -MT core/CMakeFiles/soci_core.dir/soci-simple.cpp.o -MF core/CMakeFiles/soci_core.dir/soci-simple.cpp.o.d -o core/CMakeFiles/soci_core.dir/soci-simple.cpp.o -c core/soci-simple.cpp
ninja: build stopped: subcommand failed.
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/poudriere/ports/databases/soci
*** Error code 1

Stop.
make: stopped in /usr/poudriere/ports/databases/soci

Please advise.
Comment 1 Adriaan de Groot freebsd_committer freebsd_triage 2017-12-18 09:29:27 UTC 
@neel Please follow the instructions in the error message: set MAKE_JOBS_UNSAFE=yes and rebuild. Please also include the actual error messages produced by the compiler.
Comment 2 Adriaan de Groot freebsd_committer freebsd_triage 2018-01-04 20:47:16 UTC 
Probably the same error that's hitting pkg-fallout now, and which was already spotted in armv6 and armv7. The (upstream) fix is in the review .. suggest closing this one with "feedback timeout".
Comment 3 Julien Laffaye freebsd_committer freebsd_triage 2018-01-05 07:50:38 UTC 
LGTM, please commit.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-01-05 11:06:36 UTC 
A commit references this bug:

Author: adridg
Date: Fri Jan  5 11:06:16 UTC 2018
New revision: 458126
URL: https://svnweb.freebsd.org/changeset/ports/458126

Log:
  Fix build of databases/soci w/ clang 4.0 and later and on arm6, arm7.
  Adds upstream patch to fix

  backends/mysql/session.cpp:202:22: error: ordered comparison between pointer and zero ('int *' and 'int')
              if (port < 0)

  PR:		222651 216074
  Reported by:	jbeich, Neel Chauhan
  Reviewed by:	jlaffaye
  Approved by:	tcberner (mentor)
  Obtained from:	upstream
  Differential Revision:	https://reviews.freebsd.org/D13769

Changes:
  head/databases/soci/Makefile
  head/databases/soci/files/patch-backends_mysql_session.cpp