Bug 222762 - devel/apr1 : fix build with libressl
Summary: devel/apr1 : fix build with libressl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Bernard Spil
URL: https://bz.apache.org/bugzilla/show_b...
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-10-03 19:53 UTC by Stéphane Lapie
Modified: 2017-11-08 18:25 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (apache)

Attachments
Patch to add in the files/ directory of the port (1.71 KB, text/x-csrc)
2017-10-03 19:53 UTC, Stéphane Lapie 		brnrd: maintainer-approval? (apache)
 Details
svn diff for devel/apr1 (2.95 KB, patch)
2017-10-07 21:47 UTC, Bernard Spil 		no flags Details | Diff
svn diff for devel/apr1 (2.45 KB, patch)
2017-11-08 07:12 UTC, Bernard Spil 		brnrd: maintainer-approval? (apache)
 Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Lapie 2017-10-03 19:53:17 UTC 
Created attachment 186892 [details]
Patch to add in the files/ directory of the port

I have noticed that devel/apr1 (apr-1.6.2 and apr-util-1.6.0) requires the same fixes as www/apache24.

I have written a quick patch for the version checks to ensure that OpenSSL lower than 1.1.0 or LibreSSL uses the appropriate function calls, just as was done in bug 220160 (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220160).
Comment 1 Bernard Spil freebsd_committer freebsd_triage 2017-10-07 21:47:16 UTC 
Created attachment 186990 [details]
svn diff for devel/apr1

Somehow I've missed submitting this patch as a PR.

This patch is what I use for devel/apr1 to build with LibreSSL 2.6.2 (libressl-devel)
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2017-11-05 09:56:44 UTC 
This will be addressed in the upcoming apr-1.6.3.1.6.1
Comment 3 Peter Putzer 2017-11-07 22:03:56 UTC 
(In reply to Bernard Spil from comment #2)

As Ports has updated to LibreSSL 2.6 today, any chance of an interim fix?
Comment 4 Bernard Spil freebsd_committer freebsd_triage 2017-11-08 07:12:13 UTC 
Created attachment 187839 [details]
svn diff for devel/apr1

devel/apr1: Update to 1.6.3.1.6.1

 - Fixes build with LibreSSL [1]

PR: 222762 [1]
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-11-08 08:07:08 UTC 
A commit references this bug:

Author: brnrd
Date: Wed Nov  8 08:06:09 UTC 2017
New revision: 453723
URL: https://svnweb.freebsd.org/changeset/ports/453723

Log:
  devel/apr1: Update to 1.6.3.1.6.1

   - Fixes build with LibreSSL [1]

  PR:		222762 [1]

Changes:
  head/devel/apr1/Makefile
  head/devel/apr1/distinfo
  head/devel/apr1/files/patch-apr__configure
  head/devel/apr1/files/patch-apr_poll_unix_kqueue.c
Comment 6 Bernard Spil freebsd_committer freebsd_triage 2017-11-08 18:25:41 UTC 
Was committed "With hat: apache"