Bug 222770 - devel/ninja: Update to 1.8.2
Summary: devel/ninja: Update to 1.8.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-04 08:26 UTC by Grzegorz Blach
Modified: 2017-10-10 11:13 UTC (History)
4 users (show)

See Also:
gblach: exp-run?

Attachments
Update to 1.8.2 (897 bytes, patch)
2017-10-04 08:26 UTC, Grzegorz Blach 		no flags Details | Diff
possible patch for devel/leatherman (1.45 KB, patch)
2017-10-07 18:01 UTC, Tobias C. Berner 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Blach freebsd_committer freebsd_triage 2017-10-04 08:26:06 UTC 
Since devel/ninja is used by many ports in BUILD_DEPENDS.
I think, exp-run is required to see if this upgrade don't break any port.
Comment 1 Grzegorz Blach freebsd_committer freebsd_triage 2017-10-04 08:26:32 UTC 
Created attachment 186899 [details]
Update to 1.8.2
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2017-10-07 08:28:51 UTC 
cc the CMake guys.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2017-10-07 08:32:05 UTC 
1 new failure on 10.3 amd64: devel/leatherman

http://package22.nyi.freebsd.org/data/103amd64-default-PR222770/2017-10-06_08h38m01s/logs/errors/leatherman-1.3.0_2.log

1 new failure on 10.3 i386: devel/leaherman

http://package23.nyi.freebsd.org/data/103i386-default-PR222770/2017-10-06_08h37m52s/logs/errors/leatherman-1.3.0_2.log

2 ports were not tested due to this failure
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-07 18:01:23 UTC 
Created attachment 186986 [details]
possible patch for devel/leatherman

Hi

attached is a patch for devel/leatherman that renames the gettext targets as not to coincide with the filenames.

mfg Tobias
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-10-07 18:32:45 UTC 
A commit references this bug:

Author: rakuco
Date: Sat Oct  7 18:32:19 UTC 2017
New revision: 451472
URL: https://svnweb.freebsd.org/changeset/ports/451472

Log:
  Switch to an out-of-source CMake build.

  It does not have any bad side-effects, and out-of-source builds are recommended
  by CMake. In this case, it also avoids ninja warnings that become errors with
  Ninja 1.8:

  ninja: warning: multiple rules generate locales/leatherman.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
  ninja: warning: multiple rules generate locale/locales/leatherman_locale.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]
  ninja: warning: multiple rules generate logging/locales/leatherman_logging.pot. builds involving this target will not be correct; continuing anyway [-w dupbuild=warn]

  PR:		222770

Changes:
  head/devel/leatherman/Makefile
Comment 6 Raphael Kubo da Costa freebsd_committer freebsd_triage 2017-10-07 19:07:59 UTC 
(In reply to Tobias C. Berner from comment #4)
> Created attachment 186986 [details]
> possible patch for devel/leatherman
> 
> Hi
> 
> attached is a patch for devel/leatherman that renames the gettext targets as
> not to coincide with the filenames.
> 
> mfg Tobias

Sorry for stepping on your toe, I didn't see the email and ended up finding a different fix...
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-07 19:09:13 UTC 
(In reply to Raphael Kubo da Costa from comment #6)
Yours was the better fix, so no worries :)
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2017-10-10 10:21:50 UTC 
Exp-run looks fine.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-10-10 11:12:53 UTC 
A commit references this bug:

Author: gblach
Date: Tue Oct 10 11:12:06 UTC 2017
New revision: 451661
URL: https://svnweb.freebsd.org/changeset/ports/451661

Log:
  Update to 1.8.2

  PR:		222770
  Reviewed by:	antoine

Changes:
  head/devel/ninja/Makefile
  head/devel/ninja/distinfo