Bug 222942 - misc/xfce4-weather-plugin: Update to 0.8.10
Summary: misc/xfce4-weather-plugin: Update to 0.8.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-10-12 05:04 UTC by Olivier Duchateau
Modified: 2017-10-14 12:46 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments
Patch to update misc/xfce4-weather-plugin (1.99 KB, patch)
2017-10-12 05:04 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2017-10-12 05:04:55 UTC
Created attachment 187091 [details]
Patch to update misc/xfce4-weather-plugin

- Update to 0.8.10
- Remove unneeded patch

Note: tested with xfce4-panel 4.13.1 (Gtk3 only) I noticed some icons disappeared (since switch to Gtk3, icons in panel are loaded differently), so in panel 4.12.x everythin should be fine.

Moreover in my 4.13 branch [1], I have patch, which fixes logical GtkOrientation enum (previous releases are also affected):

weather.c:2035:31: warning: implicit conversion from enumeration type 'XfcePanelPluginMode' to different enumeration type 'GtkOrientation' [-Wenum-conversion]
    data->panel_orientation = xfce_panel_plugin_get_mode(panel);
                            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
weather.c:2038:34: warning: comparison of constant 'XFCE_PANEL_PLUGIN_MODE_DESKBAR' (2) with expression of type 'GtkOrientation' is always false [-Wtautological-constant-out-of-range-compare]
        (data->panel_orientation == XFCE_PANEL_PLUGIN_MODE_DESKBAR &&
         ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

As my patch is not yet review by upstream, and follow the FreeBSD Xfce team's policy i'm waiting in order to propose my patch in the official ports tree.


[1] https://app.assembla.com/spaces/xfce4/subversion/source/HEAD/tags/4.13/misc/xfce4-weather-plugin/files/patch-panel-plugin_weather.c
Comment 1 Olivier Duchateau 2017-10-12 05:05:52 UTC
this release contains bug #222909
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-10-14 12:45:20 UTC
A commit references this bug:

Author: madpilot
Date: Sat Oct 14 12:44:29 UTC 2017
New revision: 452062
URL: https://svnweb.freebsd.org/changeset/ports/452062

Log:
  Update xfce4-weather-plugin to 0.8.10

  PR:		222942
  Submitted by:	Olivier Duchateau <duchateau.olivier@gmail.com>

Changes:
  head/misc/xfce4-weather-plugin/Makefile
  head/misc/xfce4-weather-plugin/distinfo
  head/misc/xfce4-weather-plugin/files/
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2017-10-14 12:46:14 UTC
Committed. Thanks!