Bug 222949 - net-im/qTox: Update to 1.12.1
Summary: net-im/qTox: Update to 1.12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on: 223021
Blocks:
  Show dependency treegraph
 
Reported: 2017-10-12 10:20 UTC by Yuri Victorovich
Modified: 2017-10-21 09:41 UTC (History)
1 user (show)

See Also:


Attachments
patch (4.43 KB, patch)
2017-10-12 10:20 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff
patch (5.31 KB, patch)
2017-10-12 10:23 UTC, Yuri Victorovich
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-10-12 10:20:42 UTC
Created attachment 187098 [details]
patch

QAs:
* poudriere 11.1 amd64
* portlint
* works fine

Changes:
* the port option PLATFORM_EXTENSIONS to reflect the option in CMakeLists.txt for Xorg and screensaver integration. It should be normally "on".
* pkg-message is moved into the main folder
* added LICENSE_FILE
* cmake now installs and compresses icon files
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-12 10:23:59 UTC
Created attachment 187099 [details]
patch
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-14 19:37:23 UTC
FAILED: CMakeFiles/qtox_static.dir/src/persistence/db/rawdatabase.cpp.o
ccache /usr/local/libexec/ccache/c++  -DENABLE_SYSTRAY_GTK_BACKEND=1 -DENABLE_SYSTRAY_STATUSNOTIFIER_BACKEND=1 -DGIT_DESCRIBE="\"1.12.1 (rev.cd8a7ad)\"" -DGIT_VERSION="\"build without git\"" -DLOG_TO_FILE=1 -DQTOX_PLATFORM_EXT -DQT_CORE_LIB -DQT_GUI_LIB -DQT_MESSAGELOGCONTEXT=1 -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_SVG_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DTIMESTAMP=1508009610 -DUSE_FILTERAUDIO=1 -Iqtox_static_autogen/include -I. -isystem /usr/local/include -I/usr/local/include/opus -I/usr/local/include/AL -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/libpng16 -I/usr/local/include/gtk-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libdrm -I/usr/local/include/harfbuzz -I/usr/local/include/atk-1.0 -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtOpenGL -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtSvg -isystem /usr/local/include/qt5/QtXml -O2 -pipe -fstack-protector -fno-strict-aliasing -std=c++11 -fno-exceptions -fno-rtti -fPIE -Wstrict-overflow -Wstrict-aliasing -fstack-protector-all -Wstack-protector -pthread -pthread -pthread -O2 -pipe -fstack-protector -fno-strict-aliasing   -fPIC -std=gnu++11 -MD -MT CMakeFiles/qtox_static.dir/src/persistence/db/rawdatabase.cpp.o -MF CMakeFiles/qtox_static.dir/src/persistence/db/rawdatabase.cpp.o.d -o CMakeFiles/qtox_static.dir/src/persistence/db/rawdatabase.cpp.o -c src/persistence/db/rawdatabase.cpp
src/persistence/db/rawdatabase.cpp:37:10: fatal error: 'sqlite3.h' file not found
#include <sqlite3.h>
         ^~~~~~~~~~~
1 error generated.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-14 19:46:58 UTC
Which system version?

It passes poudriere on jail 11.0-RELEASE-p7
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-14 19:48:28 UTC
(In reply to Yuri Victorovich from comment #3)
12-current
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-14 20:05:36 UTC
I never saw this problem with qTox. I will fix it and post an update.

Thanks!
Yuri
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-14 20:06:53 UTC
Thanks
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2017-10-15 07:19:09 UTC
databases/sqlcipher wasn't updated. Version 3.2.0 has a wrong .pc file not returning the proper include path.

I had the update in my ports tree, but probably forgot to submit it for commit, and previous qTox versions worked with the old sqlcipher, so nobody complained.

bug#223021 needs to be committed first.

Thanks for catching the problem, Tobias.

Yuri
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-10-21 09:39:40 UTC
A commit references this bug:

Author: tcberner
Date: Sat Oct 21 09:39:18 UTC 2017
New revision: 452583
URL: https://svnweb.freebsd.org/changeset/ports/452583

Log:
  Update net-im/qTox to 1.12.1

  * the port option PLATFORM_EXTENSIONS to reflect the option in
    CMakeLists.txt for Xorg and screensaver integration. It should
    be normally "on".
  * pkg-message is moved into the main folder
  * added LICENSE_FILE
  * cmake now installs and compresses icon files

  * while here, switch it to DISTVERSION.

  PR:		222949
  Submitted by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)

Changes:
  head/net-im/qTox/Makefile
  head/net-im/qTox/distinfo
  head/net-im/qTox/files/pkg-message.in
  head/net-im/qTox/pkg-message
Comment 9 Tobias C. Berner freebsd_committer freebsd_triage 2017-10-21 09:41:10 UTC
Committed. Thanks.