Bug 222958 - graphics/gts: moved header, graphics/netpbm fallout
Summary: graphics/gts: moved header, graphics/netpbm fallout
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-12 17:33 UTC by Phil Pennock
Modified: 2017-11-06 20:10 UTC (History)
2 users (show)

See Also:


Attachments
gts.diff (915 bytes, patch)
2017-10-21 07:42 UTC, Tobias Kortkamp
tobik: maintainer-approval? (erik)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Pennock 2017-10-12 17:33:32 UTC
Commit 9024ea4ea906 of the Ports tree landed 6 days ago, overhauling graphics/netpbm.  The commit message states:

    - Headers have been moved to ${LOCALBASE}/include/netpbm.  Fix ports
      that expect them to be in ${LOCALBASE}/include

That commit missed graphics/gts which, with `NETPBM` option on, depends upon netpbm and errors out during build with:

happrox.c:24:10: fatal error: 'pgm.h' file not found
#include <pgm.h>

That file is one of those which moved.

Changing graphics/gts/Makefile to edit CPPFLAGS worked for my use-case of getting local poudriere building again, but should probably be done "right" as USE-flag dependent.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-10-21 07:42:31 UTC
Created attachment 187341 [details]
gts.diff

Here is a patch that should fix it.

While here also clean up the port a little bit:

- Removes NETPBM_DESC since it's already in bsd.options.desc.mk
- Properly disables the netpbm check via an autoconf variable
- Switch to USES=localbase
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-11-06 20:09:57 UTC
A commit references this bug:

Author: tobik
Date: Mon Nov  6 20:09:39 UTC 2017
New revision: 453643
URL: https://svnweb.freebsd.org/changeset/ports/453643

Log:
  graphics/gts: Unbreak build WITH=NETPBM

  happrox.c:24:10: fatal error: 'pgm.h' file not found

  The netpbm update from r451378 moved netpbm headers from include/ to
  include/netpbm/, but gts looks for them in include/ only.

  While here also clean up the port a little bit:

  - Remove NETPBM_DESC since it's already in bsd.options.desc.mk
  - Disable netpbm via an autoconf variable instead of patching
    configure

  PR:		222958
  Reported by:	Phil Pennock <freebsd@phil.spodhuis.org>
  Approved by:	erik@bz.bzflag.bz (maintainer timeout, 2 weeks)

Changes:
  head/graphics/gts/Makefile