Bug 222983 - databases/py-mysqlclient: Update to 1.3.12
Summary: databases/py-mysqlclient: Update to 1.3.12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2017-10-13 15:20 UTC by Neel Chauhan
Modified: 2017-11-03 13:44 UTC (History)
4 users (show)

See Also:
koobs: maintainer-feedback? (nc)

Attachments
Patch to update py-mysqlclient to 1.3.12 (1.54 KB, patch)
2017-10-13 15:20 UTC, Neel Chauhan 		no flags Details | Diff
upgrade to 1.3.12 (1.01 KB, patch)
2017-10-24 20:14 UTC, Dan Langille 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2017-10-13 15:20:44 UTC 
Created attachment 187139 [details]
Patch to update py-mysqlclient to 1.3.12

This port builds on FreeBSD 11.1 amd64, and also resolves Bug 222965.
Comment 1 Richard Gallamore freebsd_committer freebsd_triage 2017-10-15 21:57:26 UTC 
Hello Neel, thank you for your contributions.

There are a couple of items I would like checked and also the patch fails to build.

* Are there any slave ports attached to this port? If not the set default flag (?) should probably be removed from USES.

* Setting iconv in USES by default as used here adds libiconv.so:converters/libiconv to LIB_DEPENDS, so this can be removed from Makefile.

Build failure: cp -f /usr/ports/databases/py-mysqlclient/files/mysqld_error.h /wrkdirs/usr/ports/databases/py-mysqlclient/work/mysqlclient-python-1.3.12
cp: /usr/ports/databases/py-mysqlclient/files/mysqld_error.h: No such file or directory
*** Error code 1
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-10-16 07:40:56 UTC 
Commented out (and less correct than the next line) STRIP_CMD entry should also be removed.
Comment 3 Dan Langille freebsd_committer freebsd_triage 2017-10-24 20:14:19 UTC 
Created attachment 187448 [details]
upgrade to 1.3.12
Comment 4 Dan Langille freebsd_committer freebsd_triage 2017-10-24 20:17:44 UTC 
(In reply to Richard Gallamore from comment #1)

Yes, there is a slave port: https://www.freshports.org/databases/py3-mysqlclient/

based on https://www.freshports.org/databases/py-mysqlclient/
Comment 5 Dan Langille freebsd_committer freebsd_triage 2017-10-26 14:14:04 UTC 
maintainer (In reply to Dan Langille from comment #4)
I see my patch does not deal with issues from the other ticket mentioned above. :/
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-11-03 13:02:29 UTC 
A commit references this bug:

Author: dvl
Date: Fri Nov  3 13:01:58 UTC 2017
New revision: 453402
URL: https://svnweb.freebsd.org/changeset/ports/453402

Log:
  Upgrade to 1.3.12

  maintainer timeout

  PR:		222983
  Submitted by:	Neel Chauhan

Changes:
  head/databases/py-mysqlclient/Makefile
  head/databases/py-mysqlclient/distinfo