Created attachment 187209 [details] math/pecl-bitset2 poudriere log I get a build error in poudriere for math/pecl-bitset2 see attached poudriere log
Forgot to mention: i am on FreeBSD 10.3 amd64
I did not see the same error. And here's the build log of this port on our cluster: http://beefy6.nyi.freebsd.org/data/103amd64-default/430427/logs/pecl-bitset2-2.0.3_1.log
You built 2.0.3_1, i built the brand new 2.0.4
http://beefy6.nyi.freebsd.org/data/103amd64-default/451481/logs/pecl-bitset2-2.0.4.log
Hm. So the question is: why do I face a problem here... thx
To be more precise: /etc/make.conf: DEFAULT_VERSIONS+=php=5.6 lang_php56/options: # Options for php56-5.6.31 _OPTIONS_READ=php56-5.6.31 _FILE_COMPLETE_OPTIONS_LIST=CLI CGI FPM EMBED PHPDBG DEBUG DTRACE IPV6 MAILHEAD LINKTHR ZTS OPTIONS_FILE_SET+=CLI OPTIONS_FILE_UNSET+=CGI OPTIONS_FILE_SET+=FPM OPTIONS_FILE_UNSET+=EMBED OPTIONS_FILE_UNSET+=PHPDBG OPTIONS_FILE_UNSET+=DEBUG OPTIONS_FILE_UNSET+=DTRACE OPTIONS_FILE_UNSET+=IPV6 OPTIONS_FILE_SET+=MAILHEAD OPTIONS_FILE_SET+=LINKTHR OPTIONS_FILE_SET+=ZTS results in a broken build. It used to work with pecl-bitset2-2.0.3 in this configuration
I *think* i nailed it (couldn't test, as i don't know how to incorporate a patch) down to an error in one line: --- bitset.c.orig 2017-10-06 18:29:59.000000000 +0200 +++ bitset.c 2017-11-09 11:43:23.586219000 +0100 @@ -652,7 +652,7 @@ bit_diff = intern->bitset_len * CHAR_BIT; if (start_bit > bit_diff) { - zend_throw_exception_ex(spl_ce_OutOfRangeException, 0, + zend_throw_exception_ex(spl_ce_OutOfRangeException, 0 TSRMLS_CC, "The specified index parameter exceeds the total number of bits available"); return; } Every other occurrence of zend_throw_exception_ex has the TSRMLS_CC except this one line. Can you help me in incorporating this patch to test it? Can anyone send it (after testing) upstream to the pecl-bitstream developer, as i think more people could be hit by this issue?
Ah! I got it, just put it in files/patch-bitset.c The same error is there two times. So this patch is needed for ZTS to work: --- bitset.c.orig 2017-10-06 18:29:59.000000000 +0200 +++ bitset.c 2017-11-09 18:48:12.870339000 +0100 @@ -652,7 +652,7 @@ bit_diff = intern->bitset_len * CHAR_BIT; if (start_bit > bit_diff) { - zend_throw_exception_ex(spl_ce_OutOfRangeException, 0, + zend_throw_exception_ex(spl_ce_OutOfRangeException, 0 TSRMLS_CC, "The specified index parameter exceeds the total number of bits available"); return; } @@ -696,7 +696,7 @@ bit_diff = intern->bitset_len * CHAR_BIT; if (start_bit > bit_diff) { - zend_throw_exception_ex(spl_ce_OutOfRangeException, 0, + zend_throw_exception_ex(spl_ce_OutOfRangeException, 0 TSRMLS_CC, "The specified index parameter exceeds the total number of bits available"); }
A commit references this bug: Author: sunpoet Date: Mon Dec 11 10:40:52 UTC 2017 New revision: 455971 URL: https://svnweb.freebsd.org/changeset/ports/455971 Log: Fix build PR: 223043 Submitted by: Markus Mann <freebsd-public@it64.de> MFH: 2017Q4 Changes: head/math/pecl-bitset2/files/ head/math/pecl-bitset2/files/patch-bitset.c
Committed. Thanks!
A commit references this bug: Author: sunpoet Date: Tue Dec 12 12:16:37 UTC 2017 New revision: 456123 URL: https://svnweb.freebsd.org/changeset/ports/456123 Log: MFH: r455971 Fix build PR: 223043 Submitted by: Markus Mann <freebsd-public@it64.de> Approved by: ports-secteam (delphij) Changes: _U branches/2017Q4/ branches/2017Q4/math/pecl-bitset2/files/