Bug 223156 - databases/sqlcipher: update 3.4.1 -> 3.4.2 to fix build with libressl
Summary: databases/sqlcipher: update 3.4.1 -> 3.4.2 to fix build with libressl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-22 07:16 UTC by Matthew Rezny
Modified: 2018-04-01 16:35 UTC (History)
4 users (show)

See Also:
jharris: maintainer-feedback+

Attachments
fix build with libressl (1.13 KB, patch)
2017-10-22 07:16 UTC, Matthew Rezny 		no flags Details | Diff
patch-src_openssl.c (442 bytes, text/x-csrc)
2017-12-19 06:42 UTC, Walter Schwarzenfeld 		no flags Details
update-to-3.4.2 (855 bytes, patch)
2018-02-09 20:45 UTC, Kurt Jaeger 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2017-10-22 07:16:07 UTC 
Created attachment 187358 [details]
fix build with libressl

After the update to 3.4.1, sqlcipher no longer builds with libressl. The attached patch comes from upstream's prerelease branch and resolves the build issue.
Comment 1 Walter Schwarzenfeld freebsd_triage 2017-12-19 05:27:27 UTC 
Maintainer timeout?
Comment 2 Walter Schwarzenfeld freebsd_triage 2017-12-19 06:42:41 UTC 
Created attachment 188950 [details]
patch-src_openssl.c

For unknown reasons the first patch does not work.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2018-02-09 20:41:27 UTC 
3.4.2 was released in december 2017 and fixes the libressl build problem, according to 

https://github.com/sqlcipher/sqlcipher/blob/master/CHANGELOG.md
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2018-02-09 20:45:03 UTC 
Created attachment 190470 [details]
update-to-3.4.2

TODO: testbuilds and runtests
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-02-10 01:01:44 UTC 
Poudriere test ok with 10.4amd64/i386 and 11.1amd64. 
Simple runtest works also.
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-02-10 07:30:14 UTC 
A commit references this bug:

Author: pi
Date: Sat Feb 10 07:30:02 UTC 2018
New revision: 461361
URL: https://svnweb.freebsd.org/changeset/ports/461361

Log:
  databases/sqlcipher: update 3.4.1 -> 3.4.2 to fix build with libressl

  PR:		223156
  MFH:		2018Q1
  Changes:	https://github.com/sqlcipher/sqlcipher/blob/master/CHANGELOG.md
  Submitted by:	rezny
  Approved by:	jharris@widomaker.com (maintainer timeout)

Changes:
  head/databases/sqlcipher/Makefile
  head/databases/sqlcipher/distinfo
Comment 7 jharris 2018-03-04 19:38:25 UTC 
Approved posthumously, thanks!
Comment 8 Walter Schwarzenfeld freebsd_triage 2018-04-01 16:12:33 UTC 
2018Q2 is created, I think we can close here.