Bug 223167 - databases/cockroach: Update to 1.1.1
Summary: databases/cockroach: Update to 1.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-10-22 14:14 UTC by James Nugent
Modified: 2018-01-31 16:52 UTC (History)
5 users (show)

See Also:

Attachments
Update to v1.1.1 (1.49 KB, patch)
2017-10-22 14:14 UTC, James Nugent 		no flags Details | Diff
Update to v1.1.2 (1.63 KB, patch)
2017-11-12 07:20 UTC, Charlie Li 		no flags Details | Diff
Update to 1.1.3 (1.63 KB, patch)
2017-11-28 11:26 UTC, Charlie Li 		no flags Details | Diff
update to 1.1.4 (1.63 KB, patch)
2018-01-08 23:42 UTC, Charlie Li 		no flags Details | Diff
Upgrade to 1.1.4 (2.18 KB, patch)
2018-01-27 08:15 UTC, Sean Chittenden 		no flags Details | Diff
Upgrade to crdb 1.1.4 (1.41 KB, patch)
2018-01-28 00:53 UTC, Sean Chittenden 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Nugent 2017-10-22 14:14:42 UTC 
Created attachment 187367 [details]
Update to v1.1.1

This patch updates CockroachDB to v1.1.1.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2017-10-22 14:14:42 UTC 
Maintainer informed via mail
Comment 2 James Nugent 2017-10-22 14:15:37 UTC 
This was tested using Poudriere on FreeBSD-11.1-RELEASE and 12.0-CURRENT.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2017-10-22 18:30:42 UTC 
Hello James, thank you for your contributions. I have a couple questions.

* Should the ports maintainer email be updated to the one on bugzilla?
* The port is currently marked as broken, commenting the flag will build on 111amd64 and 12amd64. The port is broken for 103amd64 and i386-all. Can you look into this issue and if not fixable mark broken for the arch/releases that are. Here are some logs.

103i386: Failed: https://poudriere.ultimasbox.com/data/103i386-test/2017-10-22_11h14m50s/logs/errors/cockroach-1.1.1.log
103amd64: Failed: https://poudriere.ultimasbox.com/data/103amd64-test/2017-10-22_11h14m49s/logs/errors/cockroach-1.1.1.log
110i386: Failed: https://poudriere.ultimasbox.com/data/111i386-test/2017-10-22_11h14m52s/logs/errors/cockroach-1.1.1.log
110amd64: Success: https://poudriere.ultimasbox.com/data/111amd64-test/2017-10-22_11h14m51s/logs/cockroach-1.1.1.log
12i386: Failed: https://poudriere.ultimasbox.com/data/12i386-test/2017-10-22_11h14m54s/logs/errors/cockroach-1.1.1.log
12amd64: Success: https://poudriere.ultimasbox.com/data/12amd64-test/2017-10-22_11h14m53s/logs/cockroach-1.1.1.log
Comment 4 Charlie Li freebsd_committer freebsd_triage 2017-11-12 07:20:15 UTC 
Created attachment 187934 [details]
Update to v1.1.2

v1.1.2 was released in the meantime, so this patch updates this port to said version.

Added NO_CCACHE due to a nonexistent/invalid filesystem access when configure runs on vendored jemalloc.

As for building on i386, upstream doesn't explicitly support it: "A 64-bit system is strongly recommended. Building or running CockroachDB on 32-bit systems has not been tested."
Comment 5 Charlie Li freebsd_committer freebsd_triage 2017-11-28 11:26:49 UTC 
Created attachment 188347 [details]
Update to 1.1.3
Comment 6 Charlie Li freebsd_committer freebsd_triage 2018-01-08 23:42:30 UTC 
Created attachment 189549 [details]
update to 1.1.4
Comment 7 Nikolai Lifanov freebsd_committer freebsd_triage 2018-01-16 20:48:48 UTC 
Hi James,

I tested the 1.1.4 update with Go 1.9 and it works. Can you take a look at Charlie's patch and address Richard's question about the maintainer email address please?
Comment 8 Nikolai Lifanov freebsd_committer freebsd_triage 2018-01-16 20:50:07 UTC 
If upstream doesn't support i386, this port needs ONLY_FOR_ARCHS and ONLY_FOR_ARCHS_REASON set.
Comment 9 Sean Chittenden freebsd_committer freebsd_triage 2018-01-27 08:15:45 UTC 
Created attachment 190097 [details]
Upgrade to 1.1.4

Updated to 1.1.4 with other suggestions in this ticket.
Comment 10 Charlie Li freebsd_committer freebsd_triage 2018-01-27 10:01:27 UTC 
Comment on attachment 190097 [details]
Upgrade to 1.1.4

Was the inclusion of devel/dep in this diff unintentional?
Comment 11 Sean Chittenden freebsd_committer freebsd_triage 2018-01-28 00:53:54 UTC 
Created attachment 190123 [details]
Upgrade to crdb 1.1.4

Upgrade `database/cockroach` to 1.1.4 (this time without `devel/dep`).
Comment 12 Sean Chittenden freebsd_committer freebsd_triage 2018-01-28 00:54:34 UTC 
@CharlieLi, yes it was.  Sorry about that.
Comment 13 Nikolai Lifanov freebsd_committer freebsd_triage 2018-01-29 14:41:37 UTC 
I just re-tested this. It looks good and is commitable.
Do you strongly prefer james@jen20.com in MAINTAINER or
can this be freebsd@jen20.com, which matches your
Bugzilla account?
Comment 14 James Nugent 2018-01-29 18:18:42 UTC 
I'd rather keep it as freebsd@jen20.com in order that mailbox filtering works properly. Sorry, I didn't realise they were set differently.
Comment 15 Nikolai Lifanov freebsd_committer freebsd_triage 2018-01-29 20:06:04 UTC 
OK, great, I'll change MAINTAINER to freebsd@jen20.com and commit.
Comment 16 commit-hook freebsd_committer freebsd_triage 2018-01-31 16:34:06 UTC 
A commit references this bug:

Author: lifanov
Date: Wed Jan 31 16:33:42 UTC 2018
New revision: 460498
URL: https://svnweb.freebsd.org/changeset/ports/460498

Log:
  databases/cockroach: unbreak and update to 1.1.4

  PR:		223167
  Submitted by:	James Nugent <freebsd@jen20.com> (maintainer)

Changes:
  head/databases/cockroach/Makefile
  head/databases/cockroach/distinfo
Comment 17 Nikolai Lifanov freebsd_committer freebsd_triage 2018-01-31 16:52:05 UTC 
Committed, thanks!