Bug 223285 - ports-mgmt/portlint: Complains about the word 'which' in the ONLY_xxx statement
Summary: ports-mgmt/portlint: Complains about the word 'which' in the ONLY_xxx statement
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 22:14 UTC by Yuri Victorovich
Modified: 2017-12-28 23:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-10-27 22:14:39 UTC
This line
> ONLY_FOR_ARCHS_REASON_amd64=    only builds with devel/flang, which is amd64-only
triggers this bogus warning:
> WARN: Makefile: [25]: possible direct use of command "which" found. use ${WHICH} instead.

Version 2.17.13
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-12-15 17:43:36 UTC
Fixed in my repo pending the next release
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-12-28 23:47:44 UTC
A commit references this bug:

Author: marcus
Date: Thu Dec 28 23:46:54 UTC 2017
New revision: 457486
URL: https://svnweb.freebsd.org/changeset/ports/457486

Log:
  Update to 2.17.15.

  * Don't check for direct command use for ONLY_FOR_ARCHS_REASON
    and NOT_FOR_ARCHS_REASON when a specific arch has been specified. [1]
  * Preserve an original variable value to make sure the check for copying
    dependecies is actually performed.
  * Don't complain about incon installation if the port is a Qt5 port. [2]
  * Check that PLIST_FILES entries do not contain %%FOO% notation. [3]
  * Check that DOCS and EXAMPLES are defined as OPTIONS when using %%PORTDOCS%%
    and %%PORTEXAMPLES%%. [4]
  * Check that if USE_LDCONFIG is defined, then the port installs shared
    objects. [5]
  * Check that when USE_KDE is defined, then USES=kde:5 is also defined. [6]
  * Ignore flavors when trying to find port directories. [7]
  * Revert the fix for 221971 (USE_GITHUB).  More debate is needed here.

  PR:		223285 [1]
  		223498 [2]
  		223539 [3]
  		223541 [4]
  		223762 [5]
  		224140 [6]
  		224245 [7]
  Submitted by:	adridg [2]
  		mat [4]
  		224245 [7]

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-12-28 23:50:09 UTC
Fixed in 2.17.15.