Bug 223337 - [new port] textproc/fzy: fast, simple fuzzy text selector for the terminal
Summary: [new port] textproc/fzy: fast, simple fuzzy text selector for the terminal
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-31 12:46 UTC by Oleh Hushchenkov
Modified: 2017-11-06 19:33 UTC (History)
2 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2017-10-31 12:46 UTC, Oleh Hushchenkov 		no flags Details | Diff
Patch v2 (3.27 KB, patch)
2017-11-06 06:48 UTC, Oleh Hushchenkov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Hushchenkov 2017-10-31 12:46:09 UTC 
Created attachment 187606 [details]
Patch

fzy is a fast, simple fuzzy text selector for the terminal with an advanced scoring algorithm.

Link: https://github.com/jhawthorn/fzy

Port tested with portlint.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-03 07:55:34 UTC 
The following changes are needed:
* Remove the 'Created by' line, they are phased out
* PORTVERSION -> DISTVERSION
* USE_GUTHUB should be moved after USES, it should be in the same section as USES
* post-install isn't needed, it should be merged into the do-install section
* same with post-install-X-on
* -g and -O3 should be patched away, preferably with REINPLACE_CMD
* improve option descriptions: explain what fzy-tmux/fzy-dvtm are

I would also ask upstream to fix the 'install' target in Makefile. I should install into $(DESTDIR)/$(PREFIX)/, not into $(DESTDIR).
Comment 2 Oleh Hushchenkov 2017-11-06 06:48:08 UTC 
(In reply to Yuri Victorovich from comment #1)

* Remove the 'Created by' line, they are phased out
Why? In other bugs with new ports this line exist.

* PORTVERSION -> DISTVERSION
Ok.

* USE_GUTHUB should be moved after USES, it should be in the same section as USES
Ok.

* post-install isn't needed, it should be merged into the do-install section
Ok.

* same with post-install-X-on
Ok.

* -g and -O3 should be patched away, preferably with REINPLACE_CMD
Ok.

* improve option descriptions: explain what fzy-tmux/fzy-dvtm are
If you know what is fzy then you must know what doing fzy-tmux and fzy-dvtm.
Comment 3 Oleh Hushchenkov 2017-11-06 06:48:41 UTC 
Created attachment 187785 [details]
Patch v2
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-11-06 18:51:52 UTC 
A commit references this bug:

Author: yuri
Date: Mon Nov  6 18:51:08 UTC 2017
New revision: 453639
URL: https://svnweb.freebsd.org/changeset/ports/453639

Log:
  New port: textproc/fzy: Interactive fuzzy text selector for the terminal

  Committed with minor changes.

  PR:		223337
  Submitted by:	Oleh Hushchenkov <gor@clogic.com.ua>
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D12971

Changes:
  head/textproc/Makefile
  head/textproc/fzy/
  head/textproc/fzy/Makefile
  head/textproc/fzy/distinfo
  head/textproc/fzy/pkg-descr
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2017-11-06 18:57:09 UTC 
Oleh,

FYI: 'Created by' is now obsolete, and will eventually be removed from all ports.

Thank you for your contribution!
Yuri
Comment 6 Oleh Hushchenkov 2017-11-06 19:33:38 UTC 
Thank you!